ERC-20 transferFrom greater than allowance not allowed #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broccolirob
requested review from
glarregay-tob,
montyly and
ggrieco-tob
as code owners
| assertEq( | ||
| balanceOf(msg.sender), | ||
| balance_sender, | ||
| "TransferFrom for more than amount approved source allowance" |
There was a problem hiding this comment.
i'm not sure if i understand the 4 error messages, if given out of context (like, when the property fails).
something like "TransferFrom for more than approval affected sender/receiver balance" should be clearer, what do you think?
There was a problem hiding this comment.
I updated the error messages, let me know if they sound clearer now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test to the ERC20 internal and external "basic" tests for ensuring that transferFrom doesn't transfer more than the allowance value. Also, updated the PROPERTIES readme with the new test.