Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about BEM and ATOMIC CSS #58

Open
ghost opened this issue Mar 16, 2020 · 1 comment
Open

Question about BEM and ATOMIC CSS #58

ghost opened this issue Mar 16, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented Mar 16, 2020

Hi,
I have a question about the bem methodology mixed with a little bit of atomic css.
For instance, we have this piece of code:

<!-- Single integration -->
   <div class="integration integration--dropbox flex items-start">
  <div class="integration__photo flex-shrink-0">
  <img class="integration__img js-lazy" data-src="src" alt="">
  </div>
  <div class="integration__text">
  <h4 class="heading h4 h4--margin-xs">Dropbox</h4>
  <p class="standard-text">Some text.</p>
  <p class="text-label text-label--styled text-label--integration text-label--dropbox">Dropbox</p>
  </div>

  </div>

You can see here we have a single block, called integration that look like this:

image integration block

For align the icon with the text element we have used flexbox, but instead of defining it on the css we have defined it throught html classes.

Now, following the bem guidelines, do you think this is correct? Or I have to put the flexbox layout in the .integration selector like normal css?


Thank you for reading

@ghost
Copy link
Author

ghost commented Apr 8, 2020

Anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants