Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve retries when no filter wheel is known and flatfield heuristic identification has to be used #210

Open
morcuended opened this issue Dec 16, 2022 · 0 comments

Comments

@morcuended
Copy link
Member

When both special treatments have to be used (flatfield heuristic identification and passing through the command line the filter wheels 52), osa tries the first 3 times adding to the command the --flatfield-heuristic but without using the filters 52 via command line. It is only on the 4th try when both arguments are passed and the command runs without problems. In the process, the sequence is vetoed because of the many trials.

This should be fixed to avoid so many unsuccessful repetitions.

try:
analysis_step.execute()
return analysis_step.rc
except Exception:
log.info(f"Failed. Return code {analysis_step.rc}")
cmd.append("--filters=52")
log.info("Trying again by setting filters 52")
analysis_step = ChargeCalibrationStage(run=f"{pedcal_run_id:05d}", command_args=cmd)
analysis_step.execute()
return analysis_step.rc

I think we tried not using the bare Except here, but somehow it was the easiest thing given the Exception in lstchain onsite calibration script (?). To be revised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant