-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
low-latency-playback-over-gaps__t2.html fails in all 8 TVs in London plugfest #152
Comments
Not resuming playback after the gap should be reported as failure rather than TIMEOUT. |
How should we detect this error? As this is unwanted behavior rather than an actual error that is thrown by the application, we would have to manually throw the error so it appears correctly in the results. Here is what comes to my mind: When play position is close enough to the beginning of the gap and the playback remains in waiting state for a certain time, throw an error. What do you think? |
The failure of currentTime is fixed by cta-wave/device-playback-task-force#123. The failure of 'Every video frame' has the following error on TV 2. FAIL: First frame found is 7, expected to start from 1. First frame number tolerance is 0. Mid frame number tolerance is 10. Frames out of order 368, 251. Last frame detected before gap 120 is within the tolerance of 'stall_tolerance_margin'=7.5 frames of expected frame 125. Total of missing frames is 6. @yanj-github What is "Frames out of order"? How should that be interpreted? |
@jpiesing It means frame 251 is detected after frame 368, I would go back to recording and navigate to frame 368 and goes frame by frame. If you have debug logs or the recording that can share with me I can have a look. |
@louaybassbouss @FritzHeiden Please see my email about sharing recordings from London with Resillion. Both TVs 2 and 4 have this issue. |
Upload in progress. Will send details to @yanj-github. |
I've labelled this as "Blocker" on the basis that we want to include this test in the release. |
cta-wave/device-playback-task-force#125 |
cta-wave/device-playback-task-force#126 also applies here |
cta-wave/device-playback-task-force#125
Frame out of order caused by duplication: Will this be test runner or device issue? The test contains duplicated duration. Frame 251 and frame 368, from the example. |
This is also what I noticed when looking at the recordings. As this test runs properly in the browser and on other TVs, I don't believe its a test runner issue. Here is my guess what is happening: When reaching the beginning of the gap, the test should wait for a specific time until skipping to the end of the gap. Some devices skip over this gap automatically and continue playing the video. As soon as the waiting time is over the test skips to the end of the gap, which in this case results in a seek backwards. |
Is it reasonable to make the test JS code detect devices that skip over the gap automatically and report a FAIL at that point? |
Implemented with #176 |
Both TVs 2 and 4 have the 'frames out of order' issue which we believe is an incorrect implementation. |
@jpiesing if fixes done on test runner I think we need a new recording and run with OF. Maybe we cannot release this due to unable to re-take recording? |
We may run this test on our selection of TVs in the lab and see if the frames out of order error still occurs, or at least is replaced by the new error from the test runner |
If the frame out of order does not occur then we can consider this resolved. |
2024-05-14: Wait to see the results from the Fraunhofer zoo check and close as discussed in the two previous comments. |
This are the results on 3 different TV sets after adding a new assertion in the test to make sure that the video remains in the waiting state. @yanj-github I will share the 3 recordings with you. |
@louaybassbouss thanks. I will check the recording once I have got them. |
@yanj-github I just sent the recordings |
@louaybassbouss from looking at the recording the issue is caused by early reporting status=finished. |
Thanks @yanj-github we will check. @FritzHeiden Please check the status reporting of |
@jpiesing and @louaybassbouss The spec stating two different modes live and VOD. I can see that we only have live mode testing but the VOD mode test is missing. |
I think there are two cases which are not properly reflected in the DPCTF spec.
I'm not sure if what we currently have is one of these or something in-between. |
This is fixed with #178 |
2028-05-28: This remains open as the DPCTF spec needs updating. |
In the London plugfest, low-latency-playback-over-gaps__t2.html failed the following 2 observation in 5 or 6 of 8 TV sets and failed to execute to completion in two more.
The text was updated successfully, but these errors were encountered: