Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cubestore): Expose parts of Config::test for customization #8930

Merged
merged 1 commit into from
Nov 8, 2024
Merged

chore(cubestore): Expose parts of Config::test for customization #8930

merged 1 commit into from
Nov 8, 2024

Conversation

srh
Copy link
Member

@srh srh commented Nov 8, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@srh srh requested a review from a team as a code owner November 8, 2024 07:33
KSDaemon
KSDaemon approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@srh srh merged commit 349597a into master Nov 8, 2024
51 checks passed
@srh srh deleted the config-test-customization branch November 8, 2024 21:28
ptiurin pushed a commit to firebolt-db/cube that referenced this pull request Nov 27, 2024
@srh @ptiurin
chore(cubestore): Expose parts of Config::test for customization (cub…
f52d5da 
…e-js#8930)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSDaemon KSDaemon KSDaemon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srh @KSDaemon