Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(databricks-driver): fix databricks bucket URL parsing. Now driver supports both (legacy and modern urls) #8968

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Nov 19, 2024

Fix databricks bucket URL parsing. Now driver supports both (legacy and modern urls)

This PR also fixes incorrect processing of databricks preaggregations exported to azure.

The legacy Windows Azure Storage Blob driver (WASB) has been deprecated. ABFS has numerous benefits over WASB. See Azure documentation on ABFS. For documentation for working with the legacy WASB driver, see Connect to Azure Blob Storage with WASB (legacy).

@KSDaemon KSDaemon requested a review from a team as a code owner November 19, 2024 12:27
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 4:35pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 4:35pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 4:35pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 4:35pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 4:35pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 4:35pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 4:35pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 4:35pm

@KSDaemon KSDaemon requested a review from a team as a code owner November 19, 2024 15:42
@KSDaemon KSDaemon changed the title chore(testing-drivers): update databricks export to azure configuration fix(databricks-driver): fix databricks bucket URL parsing. Now driver supports both (legacy and modern urls) Nov 19, 2024
@KSDaemon KSDaemon merged commit 137de67 into master Nov 19, 2024
53 checks passed
@KSDaemon KSDaemon deleted the fix/databricks-export-azure-tests branch November 19, 2024 21:22
ptiurin pushed a commit to firebolt-db/cube that referenced this pull request Nov 27, 2024
… supports both (legacy and modern urls) (cube-js#8968)

* chore(testing-drivers): update databricks export to azure configuration

* fix azure blobs filtering

* add support for azure 'dfs.core.windows.net' alongside with 'blob.core.windows.net'

* update test snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants