Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or remove intermittent failing test that uses ngx_debug_log #65

Open
gary-archer opened this issue Jul 13, 2022 · 0 comments
Open

Comments

@gary-archer
Copy link
Contributor

gary-archer commented Jul 13, 2022

This code at the start of the handler is working fine, but the debug line does not always come out in test logs when I run it, causing TEST 5 in config.t to fail intermittently. For now I have raised this minor issue in case it occurs for others.

if (!module_location_config->enable)
{
    ngx_log_debug0(NGX_LOG_DEBUG_HTTP, request->connection->log, 0, "Module disabled");
    return NGX_DECLINED;
}

Tests are configured with a debug level like this, so it should work, and the log output is written if the C code uses a higher log level (though the logging would then be wrong).

error_log /Users/userid/dev/nginx_phantom_token_module/t/servroot/logs/error.log debug;

We could disable the test like this if we cannot find a way to make it work deterministically. Perhaps debug output is flushed in a delayed manner:

--- SKIP

Currently this is not happening. It could be related to this section of the wiki.

@gary-archer gary-archer changed the title Fix or remove failing test that uses ngx_debug_log Fix or remove intermittent failing test that uses ngx_debug_log Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant