Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv_overrides check_for_duplicates does nothing #1861

Open
auscompgeek opened this issue Sep 7, 2023 · 1 comment
Open

csv_overrides check_for_duplicates does nothing #1861

auscompgeek opened this issue Sep 7, 2023 · 1 comment
Labels
bug Something isn't working talon Related to cursorless-talon

Comments

@auscompgeek
Copy link
Member

I can't see what type this is supposed to be... because I don't think any items are ever assigned to this 😕

I recall this bit was in one of the other functions previously. Think this ended up being broken after a recent refactor.

Originally posted by @auscompgeek in #1851 (comment)

@auscompgeek auscompgeek added bug Something isn't working talon Related to cursorless-talon labels Sep 7, 2023
@pokey
Copy link
Member

pokey commented Sep 7, 2023

oh wow nice catch 😅. looks like we are forgetting to update results_map in each iteration. We should fix and then do a manual check that it catches the bug. Ideally we could call the function with some mocks to add a real test that it catches duplicates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working talon Related to cursorless-talon
Projects
None yet
Development

No branches or pull requests

2 participants