Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor inaccuracy #14

Open
olleicua opened this issue Jan 22, 2014 · 0 comments
Open

Minor inaccuracy #14

olleicua opened this issue Jan 22, 2014 · 0 comments
Labels

Comments

@olleicua
Copy link

Looking at the code I noticed that in the case where we are checking for partial visibility it uses <= and >= which is technically incorrect because if the top edge of the element lines up exactly with the bottom edge of the container then it would be inaccurate to consider it visible. It's the sort of thing that rarely comes up but it's also the sort of thing that makes things like this possible:

http://www.youtube.com/watch?v=W1U5RUVENNE

@samatcd samatcd added the bug label Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants