-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor inaccuracy #14
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looking at the code I noticed that in the case where we are checking for partial visibility it uses
<=
and>=
which is technically incorrect because if the top edge of the element lines up exactly with the bottom edge of the container then it would be inaccurate to consider it visible. It's the sort of thing that rarely comes up but it's also the sort of thing that makes things like this possible:http://www.youtube.com/watch?v=W1U5RUVENNE
The text was updated successfully, but these errors were encountered: