Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for runtime configuration #3

Open
GavinJoyce opened this issue Sep 16, 2013 · 4 comments
Open

Add support for runtime configuration #3

GavinJoyce opened this issue Sep 16, 2013 · 4 comments

Comments

@GavinJoyce
Copy link
Collaborator

I'm building an application which serves many domains. Each domain has its own cookie secret so I need to be able configure the Encryptor at runtime.

I've quickly modified the rack app in my branch to achieve this:

https://github.com/RestPack/encrypted_cookie/blob/master/lib/encrypted_cookie.rb

Perhaps we could include a second version of the rack application for cases where the configuration is set at runtime? Is this something that you would be interested in including in this gem? I'll work on a proper PR with specs if you are.

@mkristian
Copy link
Contributor

+1

I would use that feature if available..

@GavinJoyce
Copy link
Collaborator Author

@cvonkleist Is this something that you'd like in this gem? Let me know and I'll cut a PR

@cvonkleist
Copy link
Owner

@GavinJoyce I'm overloaded with other projects ATM, and feeling really guilty about how long it takes me to get to issues and PRs. Making you a collaborator!

@GavinJoyce
Copy link
Collaborator Author

Great, thanks. I'll work on this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants