Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return on wantErr bypass Subtests #169

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

arifmahmudrana
Copy link

Thanks for your contribution. When I am generating test if the function has error then we add a test for wantErr then adds Subtests. But there should be a return statement also and return if wantErr e.g

t.Run(tt.name, func(t *testing.T) {
	got, err := tt.p.Write(tt.args.record)
	if (err != nil) != tt.wantErr {
		t.Errorf("parquetWriter.Write() error = %v, wantErr %v", err, tt.wantErr)
		return
	}
        //////////////////// this return should be added//////////////////////////
	if tt.wantErr {
		return
	}
        //////////////////// this return should be added//////////////////////////
        
       // There is no point checking Subtests if I want error it may create wrong test result
	if got != tt.want {
		t.Errorf("parquetWriter.Write() = %v, want %v", got, tt.want)
	}
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant