Flapping test

[andytinkham]

Summary

While adding coverage (no changes to test or app code), I'd get failures in token_file_authenticator_test.go. Rerunning the build once or twice would make them go away again.

Steps to Reproduce

Run the build repeatedly.

Expected Results

Tests act consistently

Actual Results (including error logs, if applicable)

On average about 1 in 3 times, the tests would fail, with this message:

Failures:
17:26:33
17:26:33 * /conjur-api-go/conjurapi/authn/token_file_authenticator_test.go
17:26:33 Line 27:
17:26:33 Expected: nil
17:26:33 Actual: 'Operation waitForTextFile timed out.'
17:26:33 goroutine 23 [running]:
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/reporting/reports.go:143 +0x6d
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/reporting/reports.go:103 +0x6c
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:176 +0xec
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/doc.go:125 +0x63
17:26:33 github.com/cyberark/conjur-api-go/conjurapi/authn.TestTokenFileAuthenticator_RefreshToken.func1.1()
17:26:33 /conjur-api-go/conjurapi/authn/token_file_authenticator_test.go:27 +0xbd
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/discovery.go:80 +0x24
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:261 +0x1b2
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:163 +0x48
17:26:33 github.com/jtolds/gls.(*ContextManager).SetValues.func1(0x0)
17:26:33 /go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/context.go:97 +0x466
17:26:33 github.com/jtolds/gls.EnsureGoroutineId(0xc000108480)
17:26:33 /go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/gid.go:19 +0x111
17:26:33 github.com/jtolds/gls.(*ContextManager).SetValues(0xc000068490, 0xc000108420, 0xc000091bc0)
17:26:33 /go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/context.go:63 +0x14b
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:162 +0x1bf
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/doc.go:77 +0x92
17:26:33 github.com/cyberark/conjur-api-go/conjurapi/authn.TestTokenFileAuthenticator_RefreshToken.func1()
17:26:33 /conjur-api-go/conjurapi/authn/token_file_authenticator_test.go:20 +0x1d2
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/discovery.go:80 +0x24
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:261 +0x1b2
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:110 +0xfb
17:26:33 github.com/jtolds/gls.(*ContextManager).SetValues.func1(0x0)
17:26:33 /go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/context.go:97 +0x466
17:26:33 github.com/jtolds/gls.EnsureGoroutineId.func1()
17:26:33 /go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/gid.go:24 +0x2e
17:26:33 github.com/jtolds/gls._m(0x0, 0xc000091b40)
17:26:33 /go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/stack_tags.go:108 +0x31
17:26:33 github.com/jtolds/gls.github_com_jtolds_gls_markS(0x0, 0xc000091b40)
17:26:33 /go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/stack_tags.go:56 +0x35
17:26:33 github.com/jtolds/gls.addStackTag(...)
17:26:33 /go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/stack_tags.go:49
17:26:33 github.com/jtolds/gls.EnsureGoroutineId(0xc000108330)
17:26:33 /go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/gid.go:24 +0xdf
17:26:33 github.com/jtolds/gls.(*ContextManager).SetValues(0xc000068490, 0xc0001082d0, 0xc000091b00)
17:26:33 /go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/context.go:63 +0x14b
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:105 +0x227
17:26:33 /go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/doc.go:75 +0xbe
17:26:33 github.com/cyberark/conjur-api-go/conjurapi/authn.TestTokenFileAuthenticator_RefreshToken(0xc0000b8500)
17:26:33 /conjur-api-go/conjurapi/authn/token_file_authenticator_test.go:12 +0x99
17:26:33 testing.tRunner(0xc0000b8500, 0x5cea60)
17:26:33 /usr/local/go/src/testing/testing.go:909 +0xc9
17:26:33 created by testing.(*T).Run
17:26:33 /usr/local/go/src/testing/testing.go:960 +0x350

Reproducible

• Always
• Sometimes
• Non-Reproducible