Support extra parameters in the templates #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkwmt
reviewed
May 22, 2024
There was a problem hiding this comment.
It seems that there are still some codes that need to be changed from . to .Name.
Could you please check these files as well?
cattage/charts/cattage/values.yaml
Line 47 in 29e38a5
cattage/charts/cattage/values.yaml
Line 69 in 29e38a5
Line 114 in 29e38a5
Line 131 in 29e38a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the use of extra parameters for each tenant within the AppProject and RoleBinding templates.
This feature will be useful when a tenant's name does not match GitHub team name.
The ExtraParams of a delegated tenant can be used within the templates.
However, this change introduces an error if the delegated tenant does not exist within the cluster.