Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove namespace label from custom metrics #56

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Remove namespace label from custom metrics #56

merged 1 commit into from
Jul 12, 2024

Conversation

rkwmt
Copy link
Contributor

@rkwmt rkwmt commented Jul 9, 2024 •
edited
Loading

This PR removes namespace label from custom metrics because the Tenant resource is cluster-scoped.

@rkwmt rkwmt marked this pull request as ready for review July 9, 2024 23:49
@rkwmt rkwmt requested a review from zoetrope July 9, 2024 23:50
zoetrope
zoetrope approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@zoetrope zoetrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoetrope zoetrope added the bug Something isn't working label Jul 12, 2024
@zoetrope zoetrope merged commit 73ada4c into main Jul 12, 2024
10 checks passed
@zoetrope zoetrope deleted the remove-namespace-label branch July 12, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoetrope zoetrope zoetrope approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkwmt @zoetrope