add tests for prepareForDataSynchronization func #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peng225
force-pushed
the
additional-unit-test-for-prepare-data-sync
branch
8 times, most recently
from
81de935 to
422e9f9
Compare
satoru-takeuchi
requested changes
Oct 25, 2024
| Expect(ctrlClient).NotTo(BeNil()) | ||
| primaryBackups := append(primaryBackupsWithoutTarget, backup.DeepCopy()) | ||
| for _, backup := range primaryBackups { | ||
| shouldbeDeleted := false |
There was a problem hiding this comment.
Suggested change
| shouldbeDeleted := false | |
| shouldBeDeleted := false |
There was a problem hiding this comment.
|
|
||
| var _ = Describe("prepareForDataSynchronization", func() { | ||
| testPVCUID := "d3b07384-d9a7-4e6b-8a3b-1f4b7b7b7b7b" | ||
| testName := "test5" |
There was a problem hiding this comment.
I belive "testSnap5" is better since "5" doesn't mean just a unique number among all tests but is equal to the snapID. Other testNames, "testN" should also be changed.
There was a problem hiding this comment.
peng225
force-pushed
the
additional-unit-test-for-prepare-data-sync
branch
from
422e9f9 to
a0e5141
Compare
Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
peng225
force-pushed
the
additional-unit-test-for-prepare-data-sync
branch
from
a0e5141 to
b1f8ee9
Compare
Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
|
Although |
satoru-takeuchi
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
@peng225 LGTM. Do you plan to squash commits? If else, I'll merge this PR after CI succeeded.
No, I don't. Now that CI has passed, I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shinya Hayashi shinya-hayashi@cybozu.co.jp