Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter emailOnCompletion should not e-mail a junk address by default #89

Open
mvl22 opened this issue Mar 13, 2024 · 0 comments · May be fixed by #90
Open

Parameter emailOnCompletion should not e-mail a junk address by default #89

mvl22 opened this issue Mar 13, 2024 · 0 comments · May be fixed by #90
Assignees
@Robinlovelace

Comments

@mvl22
Copy link
Member

mvl22 commented Mar 13, 2024 •
edited
Loading

The functions default to

emailOnCompletion = "you@example.com"

which results in an e-mail being emitted, but then bounced or the API's mailserver building up unsendable mail.

The default should be that no e-mail is sent, i.e. the parameter is not supplied.
@Robinlovelace Robinlovelace self-assigned this Mar 13, 2024
Robinlovelace added a commit that referenced this issue Mar 13, 2024
@Robinlovelace
Remove email option, unused, fix #89
fa1d35a
@Robinlovelace Robinlovelace linked a pull request Mar 13, 2024 that will close this issue
Remove email option, unused, fix #89 #90
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Robinlovelace Robinlovelace

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove email option, unused, fix #89 cyclestreets/cyclestreets-r
2 participants
@mvl22 @Robinlovelace