Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue with Samsung + Grammarly ? #125

Open
RobertLiuMTL opened this issue Oct 9, 2023 · 1 comment
Open

Potential issue with Samsung + Grammarly ? #125

RobertLiuMTL opened this issue Oct 9, 2023 · 1 comment
Labels
bug Something isn't working v3 Feature and fixes for the major v3 release

Comments

@RobertLiuMTL
Copy link

End 2022/Start 2023, we had to deal with an issue happening on Samsung Devices where the App would crash when Samsung Users would enter text (generally long text) in a TextInput.

The issue (now resolved) can be found here: facebook/react-native#35590

It looks like the same (?) issue is happening with the MentionInput where the App can crash if the User is mentioning someone ("@user_name") and typing a long text.

Repro steps/configuration:

  • Samsung devices with grammarly. (In my case, Samsung S10, Android 12).
  • Project is currently on react-native 0.72.4 (latest as of October 9th is 0.72.5)
  • Type "@user_name with a long text..." in . Make some mistakes along the way, which will be fixed automatically by Samsung/Grammarly. More complex errors will be underlined.
  • Keep typing until the app hangs/lags/crashes.

Workarounds

  • turn off autoComplete and autoCorrect for Samsung Users:
<MentionInput
   {...props}
   autoComplete={isSamsung ? "off" : props.autoComplete}
   autoCorrect={isSamsung ? false : props.autoCorrect}
/>
  • Less ideal: Tell the users to disable Grammarly on their phone
  • Bad: Tell the users to buy a non-Samsung phone
@dabakovich
Copy link
Owner

Hey @RobertLiuMTL

Thanks for that detailed feedback, especially for the last two workaround options 😅.

Please try to play with the pre-release third version of the library, before forcing users to buy a non-Samsung phone. It uses a slightly different approach for rendering mentions and allows you to directly use the TextInput component from react-native.

I hope it will help you. If not – please write here and we'll investigate this.

@dabakovich dabakovich added bug Something isn't working v3 Feature and fixes for the major v3 release labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v3 Feature and fixes for the major v3 release
Projects
None yet
Development

No branches or pull requests

2 participants