Skip to content

Commit

Permalink
Generate ANTLR typescript classes (#25847)
Browse files Browse the repository at this point in the history
## Summary & Motivation

Similar to #25654.

Generates the lexer/parser/base visitor interface that we'll using to
parse and evaluate the new asset selection syntax.

## How I Tested These Changes
These are generate files, no tests needed.
  • Loading branch information
salazarm authored Nov 14, 2024
1 parent b6d6b5e commit 3cdbcb8
Show file tree
Hide file tree
Showing 14 changed files with 2,592 additions and 1 deletion.
1 change: 1 addition & 0 deletions js_modules/dagster-ui/.gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ packages/core/src/**/types/* linguist-generated=true
packages/ui-core/src/graphql/* linguist-generated=true
packages/ui-core/src/**/types/* linguist-generated=true
packages/ui-core/client.json linguist-generated=true
packages/ui-core/src/asset-selection/generated/* linguist-generated=true
3 changes: 3 additions & 0 deletions js_modules/dagster-ui/packages/ui-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"ts": "tsc -p .",
"generate-graphql": "ts-node -O '{\"module\": \"commonjs\"}' ./src/scripts/generateGraphQLTypes.ts",
"generate-perms": "ts-node -O '{\"module\": \"commonjs\"}' ./src/scripts/generatePermissions.ts",
"generate-asset-selection": "ts-node -O '{\"module\": \"commonjs\"}' ./src/scripts/generateAssetSelection.ts && eslint src/asset-selection/generated/ --fix -c .eslintrc.js",
"storybook": "storybook dev -p 6006",
"build-storybook": "storybook build"
},
Expand All @@ -37,6 +38,7 @@
"@vx/shape": "^0.0.192",
"amator": "^1.1.0",
"ansi-to-react": "^5.1.0",
"antlr4ts": "0.5.0-alpha.4",
"babel-plugin-transform-import-meta": "^2.2.1",
"chart.js": "^3.4.1",
"chartjs-adapter-date-fns": "^2.0.0",
Expand Down Expand Up @@ -127,6 +129,7 @@
"@types/ws": "^6.0.3",
"@typescript-eslint/eslint-plugin": "^8.9.0",
"@typescript-eslint/parser": "^8.9.0",
"antlr4ts-cli": "0.5.0-alpha.4",
"babel-jest": "^29.7.0",
"babel-loader": "9.1.2",
"babel-plugin-graphql-tag": "^3.3.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ const FallthroughRoot = lazy(() =>
import('shared/app/FallthroughRoot.oss').then((mod) => ({default: mod.FallthroughRoot})),
);
const AssetsGlobalGraphRoot = lazy(() => import('../assets/AssetsGlobalGraphRoot'));
const CodeLocationsPage = lazy(() => import('../instance/CodeLocationsPage'));
const InstanceConfig = lazy(() => import('../instance/InstanceConfig'));
const InstanceConcurrencyPage = lazy(() => import('../instance/InstanceConcurrency'));
const InstanceHealthPage = lazy(() => import('../instance/InstanceHealthPage'));
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

1 comment on commit 3cdbcb8

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-bvi2l4xle-elementl.vercel.app

Built with commit 3cdbcb8.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.