From f43b3f6654cd3fe28287a5f6a7a64ace8e0bf81c Mon Sep 17 00:00:00 2001 From: Maxime Armstrong Date: Thu, 21 Nov 2024 13:02:35 -0500 Subject: [PATCH] Revert is_syncable property; rename to validate_syncable --- .../libraries/dagster-fivetran/dagster_fivetran/resources.py | 2 +- .../libraries/dagster-fivetran/dagster_fivetran/translator.py | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/python_modules/libraries/dagster-fivetran/dagster_fivetran/resources.py b/python_modules/libraries/dagster-fivetran/dagster_fivetran/resources.py index 34d14d7a8b5e0..5366c4bfe900f 100644 --- a/python_modules/libraries/dagster-fivetran/dagster_fivetran/resources.py +++ b/python_modules/libraries/dagster-fivetran/dagster_fivetran/resources.py @@ -635,7 +635,7 @@ def _start_sync(self, request_fn: Callable[[], Mapping[str, Any]], connector_id: connector = FivetranConnector.from_connector_details( connector_details=self.get_connector_details(connector_id) ) - connector.is_syncable() + connector.validate_syncable() if self.disable_schedule_on_trigger: self._log.info(f"Disabling Fivetran sync schedule for connector {connector_id}.") self.update_schedule_type_for_connector(connector_id, "manual") diff --git a/python_modules/libraries/dagster-fivetran/dagster_fivetran/translator.py b/python_modules/libraries/dagster-fivetran/dagster_fivetran/translator.py index be51e60ceee0f..253113051c7f5 100644 --- a/python_modules/libraries/dagster-fivetran/dagster_fivetran/translator.py +++ b/python_modules/libraries/dagster-fivetran/dagster_fivetran/translator.py @@ -64,8 +64,7 @@ def is_connected(self) -> bool: def is_paused(self) -> bool: return self.paused - @property - def is_syncable(self) -> bool: + def validate_syncable(self) -> bool: """Confirms that the connector can be sync. Will raise a Failure in the event that the connector is either paused or not fully set up. """