[dagster-looker] Use get_asset_spec().key in DagsterLookerApiTranslator #26048
+17
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 20, 2024
maximearmstrong
force-pushed
the
maxime/use-get-asset-spec-key-in-looker-translator
branch
from
575b9d8
to
f551fa8
Compare
dpeng817
reviewed
Nov 25, 2024
| def get_asset_spec(self, looker_structure: LookerStructureData) -> AssetSpec: | ||
| return super().get_asset_spec(looker_structure)._replace(metadata=expected_metadata) | ||
| default_spec = super().get_asset_spec(looker_structure) | ||
| return default_spec.replace_attributes( |
There was a problem hiding this comment.
nit: this would probably be easier done as merge_attributes, which will automatically merge the metadata dictionary
There was a problem hiding this comment.
Updated in 47484bf
dpeng817
approved these changes
Nov 25, 2024
maximearmstrong
force-pushed
the
maxime/use-get-asset-spec-key-in-looker-translator
branch
from
f551fa8
to
47484bf
Compare
maximearmstrong
deleted the
maxime/use-get-asset-spec-key-in-looker-translator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Like #26027 but for Looker API
How I Tested These Changes
Updated unit test with BK