background asset wipe #26128
Draft
background asset wipe #26128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| for ap in assetPartitionRanges | ||
| ] | ||
|
|
||
| return wipe_assets(graphene_info, normalized_ranges) |
There was a problem hiding this comment.
This mutation is intended to perform background asset wipes, but it's calling wipe_assets() instead of background_wipe_assets(). This will cause the operation to run synchronously rather than in the background as expected.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
neilfulwiler
force-pushed
the
background-asset-wipe
branch
from
00cb5c7
to
b52b2ad
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit aaad7ce. |
neilfulwiler
force-pushed
the
background-asset-wipe
branch
2 times, most recently
from
092e93e
to
e5924b0
Compare
neilfulwiler
force-pushed
the
background-asset-wipe
branch
from
e5924b0
to
aaad7ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog