Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options for the _unzipped_EPUB_ feature #106

Open
CircularKen opened this issue Apr 27, 2020 · 2 comments
Open

Options for the _unzipped_EPUB_ feature #106

CircularKen opened this issue Apr 27, 2020 · 2 comments

Comments

@CircularKen
Copy link

I like the new feature to edit metadata introduced in 1.1.0 but would ideally would like to see some more options for it.

  1. I think the production of the unzipped_EPUB folder should be an option in settings rather than always happening.
  2. I'd like to see an option to rezip the EPUB when the user has declared they have finished editing the metadata.
  3. I'd like the unzipped_EPUB folder to appear next to the EPUB not in the 'Internal Report Storage' location.
  4. If the app is to continue to write these potentially large folders to the 'Internal Report Storage' location than I'd like an option to clear unzipped_EPUB on quitting the app.
@danielweck
Copy link
Member

Thank you Ken for your feedback, let me break this down:

  1. I think the production of the unzipped_EPUB folder should be an option in settings rather than always happening.

DAISY Ace core (CLI), and by extension, the Ace App, always extract the contents of packaged EPUBs into temporary folders, in order to run the accessibility evaluations (which consist in a mix of Axe validator rules, and Ace's own rules) on individual HTML/etc. resources.

If the evaluated EPUB is already extracted, then Ace uses the original folder containing the exploded publication assets.

The metadata editor modifies the OPF XML (e.g. package.opf) directly inside the EPUB folder. This folder is packaged into an EPUB container when the user invokes the "zip" feature (after metadata edits are completed).

So in that light, could you please (re)articulate your feature request? Thank you.

  1. I'd like to see an option to rezip the EPUB when the user has declared they have finished editing the metadata.

Isn't that what the "zip" button is for already? Or is your feature request to clarify that this button is intended to be used once the user has completed the metadata edits?

screenshot

  1. I'd like the unzipped_EPUB folder to appear next to the EPUB not in the 'Internal Report Storage' location.

See point (1) above.

  1. If the app is to continue to write these potentially large folders to the 'Internal Report Storage' location than I'd like an option to clear unzipped_EPUB on quitting the app.

This is done automatically by the "tmp" subsystem, with the default settings. Have you changed the location of "Internal Report Storage", by any chance?

@danielweck
Copy link
Member

Related issue: #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants