Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated message mentions removal in a minor version #124

Open
jplatte opened this issue Apr 6, 2023 · 1 comment
Open

Deprecated message mentions removal in a minor version #124

jplatte opened this issue Apr 6, 2023 · 1 comment

Comments

@jplatte
Copy link

jplatte commented Apr 6, 2023

Currently, StaticSecret::new is deprecated with a message saying it will be removed in 2.1.0. Such a change would not be allowed as per semver. (unless 2.1.0 is supposed to be the first proper 2.x release?)
@tarcieri
Copy link
Contributor

tarcieri commented Apr 6, 2023

It'd probably be good not to remove deprecated methods in a minor version.

They can be removed in the next major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarcieri @jplatte