-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differences when running prettier more than one time over the same file content #1342
Comments
Thanks (again) for testing the native parser out, I appreciate the help in checking out the edge cases for it. May I ask how you did the tests? (i.e. how did you find out the diffs between the standard parser vs the native parser) I'm curious to know if it's actually the problem with the native parser, or if you found a bug with some unstable formatting in the library itself (unstable here means that multiple subsequent formats change the formatted code, usually it's a bug that needs fixing). |
Hello! Thanks to you for making this awesome product!!! My test was:
Following your request, in one of the classes I tried this:
This happens with both native and standard parser, so this is not longer related only to the native parser, I'm updating the title of the issue |
Hello!!
First of all congrats on the native parser solution, just ran it through my entire company code base (7500 files) and went from 1 hour and 10 minutes on the First run to 10 minutes on the native
After running it I found 4 mismatches between the first run (over an 'ugly' file) and the second run (over a 'prettied' file)
Describe your Issue
1.1. First run
1.2. Second run
2.1. First run
2.2. Second run
3.1. First run
3.2. Second run
4.1. First run
4.2. Second run
Additional information (please fill this out):
npm ls prettier-plugin-apex
): [e.g.prettier-plugin-apex@2.0.0
]npm ls prettier
): [e.g.prettier@3.0.0
]java -version
): [e.g.openjdk version "11"
]$ java -version openjdk version "21.0.2" 2024-01-16 LTS OpenJDK Runtime Environment Temurin-21.0.2+13 (build 21.0.2+13-LTS) OpenJDK 64-Bit Server VM Temurin-21.0.2+13 (build 21.0.2+13-LTS, mixed mode)
Huge congrats again on the performance boost!!!!!!!
The text was updated successfully, but these errors were encountered: