Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotracking regression in combination with ember-data-model-fragments & Ember 3.28 #109

Open
pjcarly opened this issue Feb 24, 2022 · 6 comments

Comments

@pjcarly
Copy link

pjcarly commented Feb 24, 2022

I came across an autotracking regression in Ember 3.28. And after a long investigation it appears that the combination of this addon, together with ember-data-model-fragments causes the error.

An issue has been logged there as well:
adopted-ember-addons/ember-data-model-fragments#427

@pjcarly
Copy link
Author

pjcarly commented Feb 24, 2022

Reproduction app here: https://github.com/pjcarly/autotracking-regression-repro

@edmondkong-storyful
Copy link

Hi @pjcarly , did you ever find a workaround for this?

I'm running into the same error reported in the issue you linked above while attempting to upgrade my ember application from 3.24 to 3.28.

@pjcarly
Copy link
Author

pjcarly commented May 10, 2024

I am sorry but no, in the end we stopped using ember-data-change-tracker because of this.

@edmondkong-storyful
Copy link

edmondkong-storyful commented May 10, 2024

May I ask, did you find a replacement library? Or did you have to do a refactor to mimic what ember-data-change-tracker does?

@pjcarly
Copy link
Author

pjcarly commented May 10, 2024

The last, we refactored our code to mimic this addon's behaviour, but also combined with upgrading Ember Data in order to benefit from changes in ED itself which also manage changes better.

@edmondkong-storyful
Copy link

I appreciate the responses, thank you @pjcarly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants