login failed done is not a function (OpenID)

[dennis531]

What happened?

I tried to connect LibreChat with a OpenID Connect provider but it doesn't work. It seems that the callback function signature is invalid in

LibreChat/api/strategies/openidStrategy.js

Line 101 in fc887ba

async (tokenset, userinfo, done) => {

Maybe related to #2652

Steps to Reproduce

1. Configure .env file to enable OpenID:

# OpenID
OPENID_CLIENT_ID=mytranslationapp
OPENID_CLIENT_SECRET=abc123
OPENID_ISSUER=http://localhost/studip/plugins.php/openidproviderplugin
OPENID_SESSION_SECRET=sessionsecret
OPENID_SCOPE="openid profile email"
OPENID_CALLBACK_URL=/oauth/openid/callback
OPENID_REQUIRED_ROLE=
OPENID_REQUIRED_ROLE_TOKEN_KIND=
OPENID_REQUIRED_ROLE_PARAMETER_PATH=

OPENID_BUTTON_LABEL=Stud.IP
OPENID_IMAGE_URL=

2. docker compose up
3. Login via Stud.IP OpenID Provider

What browsers are you seeing the problem on?

Firefox

Relevant log output

error log:
{"level":"error","message":"[openidStrategy] login failed done is not a function","stack":"TypeError: done is not a function\n    at OpenIDConnectStrategy._verify (/app/api/strategies/openidStrategy.js:219:11)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"}

debug log:
2024-09-17T14:40:45.124Z info: [openidStrategy] verify login openidId: undefined
2024-09-17T14:40:45.124Z debug: [openidStrategy] very login tokenset and userinfo
{
    tokenset.id_token: "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.eyJhdWQiOiJteXRyYW5zbGF0aW9uYXBwIiwiaXNzIjoiaHR0cDovL2xvY2FsaG9... [truncated]",
    tokenset.token_type: "Bearer",
    tokenset.expires_at: 1726587645,
    tokenset.access_token: "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.eyJhdWQiOiJteXRyYW5zbGF0aW9uYXBwIiwianRpIjoiMjc0NjA5Nzc5NTJmZTA... [truncated]",
    tokenset.refresh_token: "def50200dab385b421de68c208dac6f0de105aa285a78e0338781b3d9bc66baeb9086841ebc5ea37a3d1f69a2dc3e709cd2c... [truncated]",
  userinfo: function,
}

2024-09-17T14:40:45.127Z info: [openidStrategy] user found with openidId: undefined
2024-09-17T14:40:45.136Z info: [openidStrategy] login success openidId: undefined | email: test@test.de | username:

Screenshots

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[danny-avila]

I can't speak to your specific openid provider, but I just followed the instructions for Microsoft Entra here, and it worked without a hitch:

https://www.librechat.ai/docs/configuration/authentication/OAuth2-OIDC/azure

[dennis531]

I was able to solve the problem. The Stud.IP provider has no /userinfo endpoint. After I added this endpoint, the problem disappeared.