Refactored Google Drive Connector + Permission Syncing #2945
+2,045
−984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hagen-danswer
changed the title
wnmurphy
reviewed
Oct 30, 2024
web/src/app/admin/connectors/[connector]/pages/gdrive/Credential.tsx
Outdated
Show resolved
Hide resolved
|
It looks like this adds option to specify URL to a shared drive, is that right? Excited for Google Drive connector enhancements, thanks! |
wnmurphy
reviewed
Oct 30, 2024
Weves
requested changes
Oct 30, 2024
Weves
approved these changes
Oct 30, 2024
Weves
reviewed
Oct 31, 2024
There was a problem hiding this comment.
this should not be here, right?
| return accessible_file_names_for_user | ||
|
|
||
|
|
||
| def check_access_for_user( |
There was a problem hiding this comment.
for future reference, would prefer if these tests were a bit less abstracted. imo It's pretty hard to tell what's going on here (and throughout the test)
There was a problem hiding this comment.
let's chat through this (maybe as a team). but not worth re-writing these ones
Weves
approved these changes
Nov 1, 2024
Weves
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now, when using either auth flow in google, you will be able to select whether or not you want to index personal drives.
This is especially notable for orgs using the service account auth flow with permission syncing because now everyones docs can be synced and the permissions will match those in the source