Made external permissioned users and slack users show diff #3147
+288
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hagen-danswer
commented
Nov 16, 2024
| @@ -43,7 +44,10 @@ def get_total_users_count(db_session: Session) -> int: | |||
| """ | |||
| user_count = ( | |||
| db_session.query(User) | |||
There was a problem hiding this comment.
this filters out externally permissioned users
Weves
reviewed
Nov 17, 2024
| op.execute( | ||
| """ | ||
| UPDATE "user" | ||
| SET role = 'SLACK_USER' |
There was a problem hiding this comment.
default to external perm to be "least permissive"
Weves
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Externally permissioned users no longer show up in the billing/admin panel.
Slack users now show up distincly
Screen.Recording.2024-11-16.at.8.56.57.AM.mov
Mental Checklist:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.