Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15045 vos: check tls before accessing #13638

Merged
merged 2 commits into from
Feb 20, 2024
Merged

DAOS-15045 vos: check tls before accessing #13638

merged 2 commits into from
Feb 20, 2024

Conversation

wangdi1
Copy link
Contributor

@wangdi1 wangdi1 commented Jan 19, 2024

Check vos tls in vos_pool_hhash_get(), since it maybe called in the system xstream.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wangdi1 wangdi1 requested a review from a team as a code owner January 19, 2024 19:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2024 •
edited
Loading

Bug-tracker data:
Ticket title is 'Aurora soak harasser online testing 16 ecb:8 ncn - vos EMRG src/include/daos_srv/daos_engine.h:127 dss_module_key_get() Assertion 'dtls != NULL' failed'
Status is 'In Review'
Labels: 'soak,tds,triaged'
https://daosio.atlassian.net/browse/DAOS-15045

daosbuild1
daosbuild1 reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13638/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13638/1/testReport/

daosbuild1
daosbuild1 reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

jolivier23
jolivier23 previously approved these changes Jan 19, 2024
View reviewed changes
liuxuezhao
liuxuezhao previously approved these changes Jan 21, 2024
View reviewed changes
DAOS-15045 vos: vos_pool_kill should not be done in main thread
0596828 
vos_pool_kill should be executed in system xstream.

Required-githooks: true

Signed-off-by: Di Wang <di.wang@intel.com>
@wangdi1 wangdi1 dismissed stale reviews from liuxuezhao and jolivier23 via 0596828 January 22, 2024 22:40
daosbuild1
daosbuild1 reviewed Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

NiuYawei
NiuYawei previously approved these changes Jan 24, 2024
View reviewed changes
Merge branch 'release_24' into wangdi/release-24_15045
e7b9f14 
Required-githooks: true

Signed-off-by: Di Wang <di.wang@intel.com>
daosbuild1
daosbuild1 reviewed Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13638/4/execution/node/1387/log

@wangdi1
Copy link
Contributor Author

wangdi1 commented Feb 9, 2024

The failure is due to some network environment issue(swim timeout, reconnect then causing the rank dead). Since there is only 1 failure of the test, should I retrigger? or it can be landed? @daos-stack/daos-gatekeeper

02/06-22:40:31.83 wolf-140 DAOS[164382/1/5] hg ERR src/cart/crt_hg.c:1375 crt_hg_req_send_cb(0x7fb31c55fb50) [opc=0xfe020000 (SWIM) rpcid=0x1fa9c9d300263488 rank:tag=5:1] RPC failed; rc: DER_TIMEDOUT(-1011): 'Time out'
02/06-22:40:31.83 wolf-140 DAOS[164382/1/5] swim WARN src/cart/crt_swim.c:670 crt_swim_cli_cb() excluded in group version 12 (self 11)
02/06-22:40:31.83 wolf-140 DAOS[164382/1/5] server WARN src/engine/init.c:584 dss_crt_event_cb() raising SIGKILL: exclusion of this engine (rank 2) detected
"test_osa_offline_drain_daos_server_1.log.164382" 617L, 101340B

@wangdi1 wangdi1 added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Feb 9, 2024
@wangdi1 wangdi1 requested a review from a team February 9, 2024 16:55
@daltonbohning
Copy link
Contributor

Landing to 2.4 is closed until after 2.4.2 is released

@wangdi1 wangdi1 requested a review from a team February 15, 2024 15:32
@daltonbohning
Copy link
Contributor

Looks like osa/offline_drain.py is failing to destroy a pool:
https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-13638/4/tests

Is that related?

@wangdi1
Copy link
Contributor Author

wangdi1 commented Feb 16, 2024

Looks like osa/offline_drain.py is failing to destroy a pool: https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-13638/4/tests

Is that related?

no, very unlikely

daosbuild1
daosbuild1 reviewed Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@wangdi1 wangdi1 requested a review from a team February 20, 2024 15:41
@mchaarawi mchaarawi merged commit 0ec0347 into release/2.4 Feb 20, 2024
35 of 36 checks passed
@mchaarawi mchaarawi deleted the wangdi/release-24_15045 branch February 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@liuxuezhao liuxuezhao liuxuezhao approved these changes

@NiuYawei NiuYawei NiuYawei approved these changes

@jolivier23 jolivier23 jolivier23 approved these changes

Assignees
No one assigned
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wangdi1 @daosbuild1 @daltonbohning @liuxuezhao @NiuYawei @jolivier23 @mchaarawi