Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-14408 common: enable NDCTL for DCPM #14371
base: master
Are you sure you want to change the base?
DAOS-14408 common: enable NDCTL for DCPM #14371
Changes from 65 commits
ee6d615
f74f025
ceccaca
12bed56
44c0346
9598f9a
fc2c933
1f3f723
a9a4a5c
8f6e286
884f96d
5ec658a
2ca8e35
4528923
648d374
0976c04
dfb9bf0
c1dba55
d6fd878
a9a12d5
118ad26
a33e5c0
f8c108b
bcdced7
193f4e6
560d9de
3212708
f2a865e
5d4aaf2
9815445
8bd6325
cc7000b
e80ae21
1ace438
05efd1e
6e07425
dbb626b
6dd7d34
16c0519
ec653de
b0842ed
cf26dd1
8297d37
da701b4
23f52e6
83123e2
88d5087
913b030
ac3193a
4c5ed9d
eea85fb
ee99bf5
bd9100f
48f6285
4f90e7a
f4c187d
8f8d846
c9f0c11
e701bb8
e52972b
e433d4c
9175174
82e9e92
bc08b29
0565522
c6f4853
817c616
e444b1f
8d7da45
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is only used by tests, it could be a lot simpler. You can just set the value, rather than tampering with what's already there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should probably be reviewed by someone familiar with the repercussions on the engine side. Maybe @NiuYawei ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks fine. It just uses deeper stack by default for creating the vos target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we've already used deep stack size for regular pool open/create ULTs in other places, this is a missed case.