Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aurora/2.6 test branch #14539

Draft
wants to merge 12 commits into
base: release/2.6
Choose a base branch
from
Draft

aurora/2.6 test branch #14539

wants to merge 12 commits into from

Conversation

daltonbohning
Copy link
Contributor

2.6 test branch for Aurora

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning added don't land do-not-delete-branch Branch is required for CI testing labels Jun 10, 2024
@daltonbohning daltonbohning self-assigned this Jun 10, 2024
@github-actions GitHub Actions
Copy link

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/aurora/2.6

@daltonbohning daltonbohning force-pushed the aurora/2.6 branch 3 times, most recently from 54e974f to da88cb8 Compare June 20, 2024 14:43
@daltonbohning daltonbohning force-pushed the aurora/2.6 branch 2 times, most recently from 9160091 to 99b7a5a Compare July 8, 2024 20:59
@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/8/execution/node/387/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/8/execution/node/384/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/8/execution/node/380/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/8/execution/node/379/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/8/execution/node/318/log

@daltonbohning daltonbohning force-pushed the aurora/2.6 branch 4 times, most recently from fa6571a to 20cf312 Compare July 18, 2024 19:10
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/12/execution/node/824/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/13/execution/node/823/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/14/execution/node/804/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/15/execution/node/798/log

daltonbohning
daltonbohning commented Jul 25, 2024
View reviewed changes
src/tests/ftest/harness/coverage.py Outdated
@@ -6,6 +6,7 @@

from apricot import TestWithServers
from dfuse_utils import get_dfuse, start_dfuse
from general_utils import get_journalctl, journalctl_time, get_journalctl_command
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove

saurabhtandan
saurabhtandan reviewed Jul 30, 2024
View reviewed changes
src/tests/ftest/util/general_utils.py Outdated
@@ -923,7 +928,7 @@ def create_directory(hosts, directory, timeout=15, verbose=True,

"""
mkdir_command = "/usr/bin/mkdir -p {}".format(directory)
command = get_clush_command(hosts, args="-S -v", command=mkdir_command, command_sudo=sudo)
command = get_clush_command(hosts, args="-S -B -v", command=mkdir_command, command_sudo=sudo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While scaling for 2KECBs I encountered an issue while agent startup when it was unable to create dirs to be able to copy on all ECB in time. I tried increasing the timeout and that did not help either. But adding fanout to clush command helped instead.

Suggested change
command = get_clush_command(hosts, args="-S -B -v", command=mkdir_command, command_sudo=sudo)
command = get_clush_command(hosts, args="-S -B -v -f 1024", command=mkdir_command, command_sudo=sudo)

Or something like that.
Let me know what you think of adding this here in the build.
IMO if there is a way to add some higher fanout values at a single place to all clush commands in our infrastructure for Aurora, it will he helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really these direct clush commands should be replaced with run_remote, then run_remote can increase the fanout for all clush commands.

@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/20/execution/node/145/log

@daltonbohning daltonbohning force-pushed the aurora/2.6 branch 13 times, most recently from 7630e80 to 2c576b5 Compare September 5, 2024 16:38
@daltonbohning daltonbohning force-pushed the aurora/2.6 branch 2 times, most recently from fb41bc3 to ad5ab12 Compare September 9, 2024 21:01
@daltonbohning daltonbohning force-pushed the aurora/2.6 branch 2 times, most recently from abb20a9 to 7e30388 Compare September 18, 2024 17:28
daltonbohning and others added 12 commits September 24, 2024 16:46
@daltonbohning
DAOS-16447 test: set D_IL_REPORT per test (#15012)
023063a 
set D_IL_REPORT per test instead of setting defaults values in
utilities. This allows running without it set.

Features: IoctlPoolHandles IoSysAdmin performance ior dfuse soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@shimizukko @daltonbohning
DAOS-16446 test: HDF5-VOL test - Set object class and container prope… (
663d701 
#15004) #15098

In HDF5, DFS, MPIIO, or POSIX, object class and container properties are defined
during the container create. If it’s DFS, object class is also set to the IOR
parameter. However, in HDF5-VOL, object class and container properties are
defined with the following environment variables of mpirun.

HDF5_DAOS_OBJ_CLASS (Object class)
HDF5_DAOS_FILE_PROP (Container properties)

The infrastructure to set these variables are already there in run_ior_with_pool().
In file_count_test_base.py, pass in the env vars to run_ior_with_pool(env=env) as a
dictionary. Object class is the oclass variable. Container properties can be
obtained from self.container.properties.value.

This fix is discussed in PR #14964.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_io_sys_admin test_largefilecount test_smallfilecount
Required-githooks: true

Signed-off-by: Makito Kano <makito.kano@intel.com>
@daltonbohning
wip: more support for sudo-less client
031f372 
Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning
export daos-related envs in run_remote
9a65ac2 
Skip-test: true
Skip-build: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning
export daos-related envs in soak clush dfuse
b39444c 
Skip-build: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning
update agent_failure to run journalctl as user
2a43e64 
Skip-test: true
Skip-build: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@shimizukko @daltonbohning
DAOS-16076 test: Automate dmg scale test to be run on Aurora (#14616) #…
0036766 
…15126

Skip-test: true
Skip-build: true

Steps:
1. Format storages
2. System query
3. Create a 100% pool that spans all engines
4. Pool query
5. Pool destroy
6. Create 49 pools spanning all the engines with each pool using a 1/50th of the capacity
7. Pool list
8. Get around 80 pool metrics
9. Destroy all 49 pools
10. System stop
11. System start

Skip-unit-tests: true
Skip-fault-injection-test: true
Signed-off-by: Makito Kano <makito.kano@intel.com>
Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning
DAOS-16550 test: use correct stonewall file with mdtest (#15109)
938c310 
Use a dynamic stonewall file with mdtest instead of hardcoded path.

Skip-test: true
Skip-build: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning
DAOS-623 test: Support running independent io sys admin steps (#15134)
2cd69aa 
Support running independent io sys admin steps from the yaml.

Skip-test: true
Skip-build: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning
DAOS-16590 test: misc ftest/performance updates
b452c44 
- Add variants for mdtest with RP_3G1
- Update ec cell size to 1MiB for mdtest and ior easy

Skip-test: true
skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning
disable some unused / not working teardown steps
72afaff 
Skip-test: true
Skip-build: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning
optimize move_files when archiving to /lus on computes
9f107a9 
Skip-test: true
Skip-build: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhtandan saurabhtandan saurabhtandan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@daltonbohning daltonbohning

Labels
do-not-delete-branch Branch is required for CI testing don't land
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daltonbohning @daosbuild1 @saurabhtandan @shimizukko