Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-10250 control: Get enabled and disabled ranks with dmg pool query (#14436) #14548

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented Jun 11, 2024

Allow enabled and disabled ranks option to be used simultaneously (DAOS-10250).
Update and add cmocka unit tests of engine management related functions (DAOS-10253).

Fix memory leaks of ranks string in function ds_mgmt_drpc_pool_query().

Required-githooks: true

Change-Id: I27f5b3acb003faea2d53697e83f0afeb0e284080
Signed-off-by: Cedric Koch-Hofer cedric.koch-hofer@intel.com

Copy link

Bug-tracker data:
Ticket title is 'Update engine to get enabled and disabled ranks with drpc pool query'
Status is 'Resolved'
https://daosio.atlassian.net/browse/DAOS-10250

src/gurt/tests/test_gurt.c Show resolved Hide resolved
src/gurt/tests/test_gurt.c Show resolved Hide resolved
src/gurt/tests/test_gurt.c Show resolved Hide resolved
src/gurt/tests/test_gurt.c Show resolved Hide resolved
src/gurt/tests/test_gurt.c Show resolved Hide resolved
src/gurt/tests/test_gurt.c Show resolved Hide resolved
src/gurt/tests/test_gurt.c Show resolved Hide resolved
src/gurt/tests/test_gurt.c Show resolved Hide resolved
src/gurt/tests/test_gurt.c Show resolved Hide resolved
src/gurt/tests/test_gurt.c Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

@mjmac mjmac requested a review from knard-intel June 11, 2024 16:45
@mjmac
Copy link
Contributor Author

mjmac commented Jun 11, 2024

@knard-intel: FYI, I'd like to backport this to our google/2.4 branch. I had to massage it a bit to do the "old-style" pool query that is used in 2.4.x. In my local testing, it worked fine.

#14436)

Allow enabled and disabled ranks option to be used simultaneously (DAOS-10250).
Update and add cmocka unit tests of engine management related functions (DAOS-10253).

Fix memory leaks of ranks string in function ds_mgmt_drpc_pool_query().

Required-githooks: true

Change-Id: I27f5b3acb003faea2d53697e83f0afeb0e284080
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@intel.com>
@daosbuild1
Copy link
Collaborator

@mjmac mjmac requested a review from jolivier23 June 13, 2024 14:16
@mjmac
Copy link
Contributor Author

mjmac commented Jun 13, 2024

@jolivier23: Do we care about these checkpatch failures? Guessing maybe it's just due to a difference in linting rules between the branches.

@jolivier23
Copy link
Contributor

@jolivier23: Do we care about these checkpatch failures? Guessing maybe it's just due to a difference in linting rules between the branches.

I generally ignore those, particularly on cherry-picks but I would expect those to happen on master branch too unless someone changed .clang-format there

@mjmac mjmac dismissed daosbuild1’s stale review June 13, 2024 20:50

checkpatch nonsense

@mjmac mjmac requested a review from cdavis28 June 13, 2024 21:01
@knard-intel
Copy link
Contributor

@jolivier23: Do we care about these checkpatch failures? Guessing maybe it's just due to a difference in linting rules between the branches.

I generally ignore those, particularly on cherry-picks but I would expect those to happen on master branch too unless someone changed .clang-format there

It seems to fail on lines not updated by this PR.

@mjmac mjmac merged commit b13e973 into google/2.4 Jun 14, 2024
33 of 34 checks passed
@mjmac mjmac deleted the mjmac/DAOS-10250 branch June 14, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants