Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16001 placement: fix cases for delay_rebuild #14558

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

jolivier23
Copy link
Contributor

Features: rebuild
Allow-unstable-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

github-actions bot commented Jun 12, 2024

Bug-tracker data:
Ticket title is 'data mismatch found for delay_rebuild mode in exclude+reintegrate test'
Status is 'In Progress'
Labels: 'google-cloud-daos,scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-16001

@jolivier23 jolivier23 requested a review from cdavis28 June 12, 2024 12:36
@jolivier23
Copy link
Contributor Author

@cdavis28 I haven't been able to reproduce the corruption with this cherry-pick

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14558/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14558/1/testReport/

Features: rebuild
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@cdavis28
Copy link
Contributor

Losing track of pending code changes...
Do we still want this change?

@jolivier23
Copy link
Contributor Author

Yes, this is the one that fixes corruption on reintegration with delay_rebuild

@liuxuezhao
Copy link
Contributor

my PR #14557 with a few CI test case failures, but I checked looks not really related. I changed a few test yaml file and test again. no change in functional code compared to this PR.

@jolivier23 jolivier23 merged commit 5f96988 into google/2.4 Jun 14, 2024
33 of 34 checks passed
@jolivier23 jolivier23 deleted the jvolivie/fix_rebuild branch June 14, 2024 14:42
jolivier23 pushed a commit that referenced this pull request Jun 21, 2024
Placement fixes for delayed rebuild

* Note: this is just a partial backport of stuff that changed since
we backported it (See #14558) before it landed on master branch.

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
jolivier23 added a commit that referenced this pull request Jun 24, 2024
Placement fixes for delayed rebuild

* Note: this is just a partial backport of tests that changed since
we backported it (See #14558) before it landed on master branch.

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants