Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16569 vos: fix few defects #15175

Merged
merged 3 commits into from
Sep 25, 2024
Merged

DAOS-16569 vos: fix few defects #15175

merged 3 commits into from
Sep 25, 2024

Conversation

NiuYawei
Copy link
Contributor

@NiuYawei NiuYawei commented Sep 24, 2024 •
edited
Loading

  • Clear dth before yield, restore dth after back from yield.
  • Use correct object pointer for the SCM reserve on update code path.
  • Use telemetry gauge interface instead of counter interface for page stats.

Required-githooks: true

Signed-off-by: Niu Yawei yawei.niu@intel.com

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@NiuYawei NiuYawei requested review from a team as code owners September 24, 2024 03:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Ticket title is 'VOS unit tests for phase2 mode'
Status is 'In Progress'
Labels: 'md_on_ssd2'
https://daosio.atlassian.net/browse/DAOS-16569

@NiuYawei NiuYawei requested review from Nasf-Fan, sherintg and wangshilong and removed request for a team September 24, 2024 03:34
@NiuYawei
DAOS-16569 vos: fix few defects
1e13d3f 
- Clear dth before yield, restore dth after back from yield.
- Use correct object pointer for the SCM reserve on update code path.
- Use telemetry gauge interface instead of counter interface for page stats.

Required-githooks: true

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
@NiuYawei NiuYawei force-pushed the niu/vos_on_blob_p2/DAOS-16569-bugfix branch from 4e43922 to 1e13d3f Compare September 24, 2024 06:05
@NiuYawei NiuYawei changed the title DAOS-16569 vos: fix two defects DAOS-16569 vos: fix few defects Sep 24, 2024
Nasf-Fan
Nasf-Fan approved these changes Sep 24, 2024
View reviewed changes
src/vos/vos_internal.h
d_tm_set_counter(vcm->vcm_pg_free, cache->ca_pgs_stats[UMEM_PG_STATS_FREE]);
d_tm_set_gauge(vcm->vcm_pg_ne, cache->ca_pgs_stats[UMEM_PG_STATS_NONEVICTABLE]);
d_tm_set_gauge(vcm->vcm_pg_pinned, cache->ca_pgs_stats[UMEM_PG_STATS_PINNED]);
d_tm_set_gauge(vcm->vcm_pg_free, cache->ca_pgs_stats[UMEM_PG_STATS_FREE]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] Different from the counter, refreshing the gauge may cause more overhead. So it may be better to do that only when related stats changed.

@NiuYawei
DAOS-16569 vos: non-NULL check for metrics
8717180 
non-NULL check for metrics in obj_pin_bkt().

Required-githooks: true

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
@NiuYawei
DAOS-16569 vos: avoid find in emtpy daos array
6488828 
DAOS array doesn't support searching in empty array.

Required-githooks: true

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
@NiuYawei NiuYawei merged commit b7c83cf into feature/vos_on_blob_p2 Sep 25, 2024
52 of 53 checks passed
@NiuYawei NiuYawei deleted the niu/vos_on_blob_p2/DAOS-16569-bugfix branch September 25, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nasf-Fan Nasf-Fan Nasf-Fan approved these changes

@sherintg sherintg Awaiting requested review from sherintg

@wangshilong wangshilong Awaiting requested review from wangshilong

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiuYawei @Nasf-Fan