Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenesisProtocol : Calculate Redeemable values off chain #300

Open
orenyodfat opened this issue Jul 29, 2018 · 3 comments
Open

GenesisProtocol : Calculate Redeemable values off chain #300

orenyodfat opened this issue Jul 29, 2018 · 3 comments

Comments

@orenyodfat
Copy link
Contributor

orenyodfat commented Jul 29, 2018 •
edited
Loading

To eliminate calls to :
getRedeemableTokensStaker
getRedeemableReputationStaker
getRedeemableTokensVoter
getRedeemableReputationVoter
getRedeemableReputationProposer
getRedeemableTokensStakerBounty

see daostack/arc#501
@dkent600
Copy link
Contributor

Can we please include in this Arc documentation that clearly provides formulas for computing all of these removed functions?

@orenyodfat
Copy link
Contributor Author

this funcs will not be removed.
we might consider to make these internal.

@dkent600
Copy link
Contributor

dkent600 commented Aug 2, 2018 •
edited
Loading

Keeping the logic in two places can cause problems down the road. Note the decision has been taken not to remove these functions from the contract API.

@dkent600 dkent600 closed this as completed Aug 2, 2018
@dkent600 dkent600 reopened this Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkent600 @orenyodfat