Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when create a new discussion/proposal- the chat remains open with previews channel details #1990

Closed
NoamQA opened this issue Aug 17, 2023 · 4 comments · Fixed by #1997 or #2063
Closed

when create a new discussion/proposal- the chat remains open with previews channel details #1990

NoamQA opened this issue Aug 17, 2023 · 4 comments · Fixed by #1997 or #2063
Assignees
@andreymikhadyuk
Labels
bug Something isn't working Priority - B V [dev] verified on dev enviroment V [production] verified on production enviroment

Comments

@NoamQA
Copy link
Collaborator

NoamQA commented Aug 17, 2023 •
edited by elatif2020
Loading

the chat should refresh and show the new created channel
Also the active item (in the feed) should be the newly created item

Image
@NoamQA NoamQA added bug Something isn't working high priority labels Aug 17, 2023
@elatif2020 elatif2020 assigned budnik9 and unassigned elatif2020 Aug 17, 2023
@andreymikhadyuk andreymikhadyuk self-assigned this Aug 21, 2023
@andreymikhadyuk andreymikhadyuk linked a pull request Aug 21, 2023 that will close this issue
when delete a discussion/proposal - the chat stays open #1961 #1997
Merged
4 tasks
@NoamQA NoamQA added the V [dev] verified on dev enviroment label Aug 21, 2023
@elatif2020
Copy link
Collaborator

For me still the previous item remain on focus (it should switch to the new item)
@andreymikhadyuk
@NoamQA fyi

@elatif2020 elatif2020 reopened this Sep 11, 2023
@andreymikhadyuk andreymikhadyuk linked a pull request Sep 12, 2023 that will close this issue
when create a new discussion/proposal- the chat remains open with previews channel details #1990 #2063
Merged
4 tasks
@andreymikhadyuk andreymikhadyuk removed the V [dev] verified on dev enviroment label Sep 12, 2023
andreymikhadyuk added a commit that referenced this issue Sep 12, 2023
@andreymikhadyuk
Merge pull request #2063 from daostack/bugfix/CW-1990-select-created-…
6e6f57e 
…item

when create a new discussion/proposal- the chat remains open with previews channel details #1990
@NoamQA
Copy link
Collaborator Author

NoamQA commented Sep 12, 2023

@elatif2020
it works fine for me
can you also test it?

@elatif2020
Copy link
Collaborator

@NoamQA @andreymikhadyuk
Yes now it's good

@elatif2020 elatif2020 added the V [dev] verified on dev enviroment label Sep 12, 2023
@NoamQA NoamQA added the V [production] verified on production enviroment label Sep 13, 2023
@NoamQA
Copy link
Collaborator Author

NoamQA commented Sep 13, 2023

@elatif2020
works fine for me
can you verify it works for you in prod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreymikhadyuk andreymikhadyuk

Labels
bug Something isn't working Priority - B V [dev] verified on dev enviroment V [production] verified on production enviroment
Projects
None yet
Milestone
No milestone
4 participants
@andreymikhadyuk @budnik9 @elatif2020 @NoamQA