Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE mark as unread\read functionality #2017

Closed
3 tasks done
elatif2020 opened this issue Aug 27, 2023 · 6 comments · Fixed by #2050
Closed
3 tasks done

FE mark as unread\read functionality #2017

elatif2020 opened this issue Aug 27, 2023 · 6 comments · Fixed by #2050
Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Aug 27, 2023

  • Option to mark feed (and inbox) items as unread in the actions menu
    Similar to Telegram
    Available if all message have been read
    Should call the BE to mark unread - see BE ticket https://github.com/daostack/common-backend/issues/2029

  • Show an indication on the cards - a purple circle without a number
    This indication should disappear once the user opens up the relevant chat again.
    When there are new messages - change to the regular indication

  • Option to mark item (if it's unread\ with new messages) as read, in which case unread & new messages indications are cleared

See design for the icon

@elatif2020 elatif2020 changed the title FE mark as unread functionality FE mark as unread\read functionality Aug 27, 2023
@budnik9
Copy link
Contributor

budnik9 commented Sep 5, 2023

@elatif2020 Should I use the same icon for "mark as read" action as for "mark as unread" action?

@elatif2020
Copy link
Collaborator Author

@elatif2020 Should I use the same icon for "mark as read" action as for "mark as unread" action?

yes

@budnik9
Copy link
Contributor

budnik9 commented Sep 8, 2023

@elatif2020 In the current implementation, we don't have actions menu for direct messages feed items. Should we show an actions menu with the action "mark as read/unread" for DM items?

@budnik9
Copy link
Contributor

budnik9 commented Sep 8, 2023

@danielr18 It seems like I found an issue on the backend side. When I mark a feed item as seen, common member related statistics is not updated
image

cc @elatif2020

@elatif2020
Copy link
Collaborator Author

elatif2020 commented Sep 10, 2023

@elatif2020 In the current implementation, we don't have actions menu for direct messages feed items. Should we show an actions menu with the action "mark as read/unread" for DM items?

Probably we should do it, but let's split it to another ticket.

@elatif2020
Copy link
Collaborator Author

elatif2020 commented Sep 10, 2023

@danielr18 It seems like I found an issue on the backend side. When I mark a feed item as seen, common member related statistics is not updated image

cc @elatif2020

@danielr18
Maybe we should reopen the BE ticket for this https://github.com/daostack/common-backend/issues/2029
Or this https://github.com/daostack/common-backend/issues/1965

@budnik9 budnik9 linked a pull request Sep 11, 2023 that will close this issue
3 tasks
budnik9 added a commit that referenced this issue Sep 11, 2023
…-as-unread

FE mark as unread\read functionality #2017
@NoamQA NoamQA added the V [dev] verified on dev enviroment label Sep 11, 2023
@NoamQA NoamQA added the V [production] verified on production enviroment label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants