Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable editing circles (roles) names #2072

Closed
elatif2020 opened this issue Sep 13, 2023 · 2 comments · Fixed by #2082
Closed

Enable editing circles (roles) names #2072

elatif2020 opened this issue Sep 13, 2023 · 2 comments · Fixed by #2082
Assignees
Labels
Priority - A V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Sep 13, 2023

In the edit space\common at the end
Add Title Roles
with editable fields with current roles name (circles names)
don't show project circles (type: project)
call the edit roles endpoint https://github.com/daostack/common-backend/issues/2041
See design here

@roienatan roienatan linked a pull request Sep 14, 2023 that will close this issue
3 tasks
@roienatan
Copy link
Collaborator

@roienatan
Copy link
Collaborator

Keep getting 400 status code "Validation issue: newName is a required field (c67e77b1-9212-4b15-a3f4-93378ca72496)" for the below payload:

{
	"commonId": "d2bb2e62-79e2-421a-b581-eee0f3f360a3",
	"userId": "xVKzzYHqsSPrcfKgOcwmSgPj8HE3",
	"changes": [{
		"circleId": "27bd770d-b3bf-4081-963e-f2ae478b4117",
		"newName": "Member_NEW_NAME"
	}, {
		"circleId": "ed6909cc-29af-42c5-bfac-1a11ecbb8726",
		"newName": "Contributor"
	}, {
		"circleId": "f09828a5-73b8-4cf8-b2af-76833b87f9f4",
		"newName": "Admin"
	}]
}

Need @ariel-dao @danielr18 to investigate.

@roienatan roienatan removed the blocked label Sep 23, 2023
roienatan added a commit that referenced this issue Sep 27, 2023
…-roles-names

Enable editing circles (roles) names #2072
@elatif2020 elatif2020 added the V [production] verified on production enviroment label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - A V [production] verified on production enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants