Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete the profile page changes #2194

Closed
5 tasks done
elatif2020 opened this issue Oct 12, 2023 · 4 comments · Fixed by #2206 or #2225
Closed
5 tasks done

Complete the profile page changes #2194

elatif2020 opened this issue Oct 12, 2023 · 4 comments · Fixed by #2206 or #2225
Assignees
@andreymikhadyuk
Labels
Priority - A V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Oct 12, 2023 •
edited by andreymikhadyuk
Loading

Web:

  • Add icons to the profile dropdown (lower priority)
  • Push notifications dropdown should be enabled only if mobile app is installed (need to verify this)
  • UI updates to the profile pages (lower priority)

Web designs

Mobile:

  • UI updates to the billing page (in priority)
  • UI updates to other profile pages (lower priority)

Mobile designs
@elatif2020 elatif2020 mentioned this issue Oct 12, 2023
Closed
9 tasks
@andreymikhadyuk
Copy link
Collaborator

@elatif2020 Should we have bottom tabs on billing page?

@elatif2020
Copy link
Collaborator Author

@elatif2020 Should we have bottom tabs on billing page?

@andreymikhadyuk
no don't need it

@andreymikhadyuk andreymikhadyuk linked a pull request Oct 17, 2023 that will close this issue
Complete the profile page changes #2194 #2206
Merged
4 tasks
andreymikhadyuk added a commit that referenced this issue Oct 17, 2023
@andreymikhadyuk
Merge pull request #2206 from daostack/feature/CW-2194-profile
63ba32d 
Complete the profile page changes #2194
@elatif2020
Copy link
Collaborator Author

@andreymikhadyuk
There is a mistake in the design:
on mobile we have edit profile twice - in the top right pencil and in text below the picture. We should remove the "Edit profile" text.

@andreymikhadyuk andreymikhadyuk linked a pull request Oct 23, 2023 that will close this issue
Complete the profile page changes - Remove edit button from mobile #2194 #2225
Merged
3 tasks
andreymikhadyuk added a commit that referenced this issue Oct 23, 2023
@andreymikhadyuk
Merge pull request #2225 from daostack/feature/CW-2194-remove-edit-pr…
e162ab9 
…ofile-btn

Complete the profile page changes - Remove edit button from mobile #2194
@NoamQA
Copy link
Collaborator

NoamQA commented Oct 23, 2023 •
edited
Loading

web changes looks fine on web stage and mobile app

@NoamQA NoamQA added the V [production] verified on production enviroment label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreymikhadyuk andreymikhadyuk

Labels
Priority - A V [production] verified on production enviroment
Projects
None yet
Milestone
No milestone
3 participants
@andreymikhadyuk @elatif2020 @NoamQA