Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking Reset or Hamburger menu in some module hearders toggles the open/close #17985

Closed
paperdigits opened this issue Dec 10, 2024 · 4 comments
Assignees
Labels
bug: pending someone needs to start working on that priority: high core features are broken and not usable at all, software crashes reproduce: confirmed a way to make the bug re-appear 99% of times has been found
Milestone

Comments

@paperdigits
Copy link
Contributor

paperdigits commented Dec 10, 2024

Describe the bug

In the Export module, clicking the Reset of Hamburger menu toggles the open/close action of the module. c/o #17979

Steps to reproduce

  1. Go to the lighttable view.
  2. Click the Reset button on the Export Module
  3. The module opens (if closed) or closes (if open).

Expected behavior

It shouldn't toggle open/close if there is a button there, even if the button is inactive.

Logfile | Screenshot | Screencast

No response

Commit

#17979

Where did you obtain darktable from?

self compiled

darktable version

23a71cd

What OS are you using?

Linux

What is the version of your OS?

NixOS 24.11

Describe your system?

Wayland, openCL off

Are you using OpenCL GPU in darktable?

No

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

@elstoc
Copy link
Contributor

elstoc commented Dec 10, 2024

There's a similar issue with the on/off button toggle in processing modules. I think it's because the buttons are using a toggle action and I don't know how to stop the button release event from firing as well.

There's a reason I don't do darktable coding any more. I've forgotten how all this stuff hangs together.

@elstoc elstoc added reproduce: confirmed a way to make the bug re-appear 99% of times has been found bug: pending someone needs to start working on that labels Dec 10, 2024
@elstoc elstoc added this to the 5.0 milestone Dec 10, 2024
@elstoc
Copy link
Contributor

elstoc commented Dec 10, 2024

Apart from reverting my PR, I don't know how to resolve this

@TurboGit
Copy link
Member

Hopefully this does not break something else...

Can you test #17987? TIA

@TurboGit TurboGit added the priority: high core features are broken and not usable at all, software crashes label Dec 11, 2024
@TurboGit TurboGit self-assigned this Dec 11, 2024
@elstoc
Copy link
Contributor

elstoc commented Dec 11, 2024

This looks to be fixed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: pending someone needs to start working on that priority: high core features are broken and not usable at all, software crashes reproduce: confirmed a way to make the bug re-appear 99% of times has been found
Projects
None yet
Development

No branches or pull requests

3 participants