Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ffigen] Fix the weekly bot #1636

Merged
merged 2 commits into from
Oct 8, 2024
Merged

[ffigen] Fix the weekly bot #1636

merged 2 commits into from
Oct 8, 2024

Conversation

liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Oct 7, 2024 •
edited
Loading

The weekly bot failed again https://github.com/dart-lang/native/actions/runs/11197253228/job/31126969184. Fixes:

  • Updated the workflow so that it also runs on any PR that alters that file
  • Updated the version of flutter
  • Pass the new --main-thread-dispatcher flag to setup.dart

Fixes #1617

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Oct 7, 2024
@liamappelbe liamappelbe changed the title [ffigen] Update the version of flutter on the weekly bot [ffigen] Fix the weekly bot Oct 8, 2024
@liamappelbe liamappelbe marked this pull request as ready for review October 8, 2024 00:27
@liamappelbe liamappelbe merged commit fa6ffec into main Oct 8, 2024
5 checks passed
@liamappelbe liamappelbe deleted the ffigen_weekly_fix branch October 8, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcharkes dcharkes dcharkes approved these changes

@HosseinYousefi HosseinYousefi Awaiting requested review from HosseinYousefi

Assignees
No one assigned
Labels
type-infra A repository infrastructure change or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ffigen] Failure on weekly arm64 bot
2 participants
@liamappelbe @dcharkes