Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator for publishing rate #4392

Open
jonasfj opened this issue Sep 18, 2024 · 3 comments
Open

Validator for publishing rate #4392

jonasfj opened this issue Sep 18, 2024 · 3 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@jonasfj
Copy link
Member

jonasfj commented Sep 18, 2024

Proposal:

If you've published more than 5 versions over the past 30 days, then publishing validations throw an error.

This can be ignored with --skio-validation.

We can fetch versions from the API, which has a published date-time.

It's a simple way to limit publishing without making a hard limit. Also we can put in a message pointing to dart.dev/go/publishing-frequency. Then we can document guidelines for publishing rate, and document out limits.

@sigurdm
Copy link
Contributor

sigurdm commented Sep 24, 2024

Let's start by writing dart.dev/go/publishing-frequency. It will add value on its own

@sigurdm sigurdm added the type-enhancement A request for a change that isn't a bug label Sep 24, 2024
@sigurdm
Copy link
Contributor

sigurdm commented Sep 24, 2024

We should probably make this a warning only...

@jonasfj
Copy link
Member Author

jonasfj commented Oct 9, 2024

We should probably make this a warning only...

I'd be down for having two rate-limits:

  • Error at:
    • 20 publications past week (20 versions/week)
    • 32 publications past month (~ 8 versions/week)
    • 50 publications past 3 months (~ 4 versions/week)
    • 100 publications past year (~ 2 versions/week)
  • Warning at:
    • 15 publications past week (18 versions/week)
    • 24 publications past month (~ 6 versions/week)
    • 60 publications past 3 months (~ 5 versions/week)
    • 75 publications past year (~ 1.5 versions/week)

Credits to istvans proposed rates in dart-lang/pub-dev#8063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants