[CP] Pub: Validate lockfile before recompiling global executable

[sigurdm]

Commit(s) to merge

https://dart-review.googlesource.com/c/sdk/+/389720

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/391120

Issue Description

When running a dart pub global run of a package

• the package was dart pub global activated with an earlier sdk
• that depends on a sdk package (ie package:_macros)

Pub would not pick up that the package:_macros package has changed and

What is the fix

Validate the lockfile before recompiling the global executable

Why cherry-pick

This will avoid weird compilation errors about missing api when running globally activated packages like intl_utils.

$ ../../../.pub-cache/hosted/pub.dev/analyzer-6.5.0/lib/src/summary2/macro_application.dart:1261:7: Error: The non-abstract class '_StaticTypeImpl' is missing implementations for these members:
 - StaticType.asInstanceOf
Try to either
 - provide an implementation,
 - inherit an implementation from a superclass or mixin,
 - mark the class as abstract, or
 - provide a 'noSuchMethod' implementation.

class _StaticTypeImpl implements macro.StaticType {
      ^^^^^^^^^^^^^^^
/opt/flutter/bin/cache/dart-sdk/pkg/_macros/lib/src/api/introspection.dart:119:28: Context: 'StaticType.asInstanceOf' is defined here.
  Future<NamedStaticType?> asInstanceOf(TypeDeclaration declaration);

Risk

Medium-low

Issue link(s)

dart-lang/pub#4406

Extra Info

No response

[dart-github-bot]

Summary: When running dart pub global run for a package activated with an older SDK that depends on a SDK package (e.g., package:_macros), Pub fails to recognize changes in the SDK package, leading to compilation errors. The fix validates the lockfile before recompiling the global executable.

[jonasfj]

LGTM, the _macros issue affects all globally activate packages that use package:analyzer.

[itsjustkevin]

Approved CC @athomas

[sigurdm]

Landed