From 3d44fcae753e906bb4efa3040d8a6046ddec606e Mon Sep 17 00:00:00 2001 From: Yaroslav Vorobev Date: Wed, 28 Jun 2023 21:22:07 +0300 Subject: [PATCH] feat(test): add MOZ_AUTOMATION=1 to ff test runner (#2049) this ensures that ff launcher on windows wait for browser instead of creating detached instance and quitting for more info see ff wiki: https://wiki.mozilla.org/Platform/Integration/InjectEject/Launcher_Process/#Starting_Firefox_via_Automation_.2F_Scripting --- pkgs/test/CHANGELOG.md | 2 ++ pkgs/test/lib/src/runner/browser/firefox.dart | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/pkgs/test/CHANGELOG.md b/pkgs/test/CHANGELOG.md index f3e7a66b5..20731fd72 100644 --- a/pkgs/test/CHANGELOG.md +++ b/pkgs/test/CHANGELOG.md @@ -8,6 +8,8 @@ * Add support for `SAFARI_EXECUTABLE`, `FIREFOX_EXECUTABLE` and `MS_EDGE_EXECUTABLE` for custom browser installations. * Allow the latest analyzer (6.x.x). +* Add `MOZ_AUTOMATION=1` environmental variable to Firefox runner, to make + launcher process on Windows wait for browser exit. ## 1.24.3 diff --git a/pkgs/test/lib/src/runner/browser/firefox.dart b/pkgs/test/lib/src/runner/browser/firefox.dart index 50fdecfcb..39e1ac590 100644 --- a/pkgs/test/lib/src/runner/browser/firefox.dart +++ b/pkgs/test/lib/src/runner/browser/firefox.dart @@ -47,7 +47,8 @@ class Firefox extends Browser { '--no-remote', ...settings.arguments, ], environment: { - 'MOZ_CRASHREPORTER_DISABLE': '1' + 'MOZ_CRASHREPORTER_DISABLE': '1', + 'MOZ_AUTOMATION': '1', }); unawaited(process.exitCode.then((_) => Directory(dir).deleteWithRetry()));