Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is workspace supported? #2496

Closed
arnaud-secondlayer opened this issue Sep 23, 2024 · 5 comments
Closed

Is workspace supported? #2496

arnaud-secondlayer opened this issue Sep 23, 2024 · 5 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:webdev triaged

Comments

@arnaud-secondlayer
Copy link

I've started to use dartlang workspace feature in our repo ( dart-lang/sdk#53875 ).
When I run webdev on a repo with resolution: workspace, I get the error message:

Waiting for webdev serve to start...
webdev could not run in the current directory.
Cannot open file
  pubspec.lock
@parlough
Copy link
Member

\cc @sigurdm

@bkonyi
Copy link
Collaborator

bkonyi commented Sep 24, 2024

Since taking over webdev, I'm not aware of any work that's been done related to workspaces in the tool. @sigurdm, I'm assuming we'll need to make some changes to support this?

@bkonyi bkonyi added P1 A high priority bug; for example, a single project is unusable or has many test failures triaged labels Sep 24, 2024
@sigurdm
Copy link
Contributor

sigurdm commented Sep 24, 2024

Yeah - I haven't looked deeply yet. But I guess we have to remove assumptions about the location of .dart_tool/package_config.json and pubspec.lock somewhere.

With workspaces we cannot assume that they are located next to pubspec.yaml, but we have to keep looking up the file hierarchy until we find it.

I hope to get to look into this later this week.

@bkonyi
Copy link
Collaborator

bkonyi commented Sep 26, 2024

Thanks for the fix @sigurdm! This feature is going out with the next stable, right? I'll make a point to publish this soon.

@bkonyi bkonyi self-assigned this Sep 26, 2024
@sigurdm
Copy link
Contributor

sigurdm commented Sep 27, 2024

It is already available (though not announced) in 3.5, but yeah - we plan to announce it with 3.6

@sigurdm sigurdm closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:webdev triaged
Projects
None yet
Development

No branches or pull requests

4 participants