Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception thrown when parsing numbers with thousands comma separators #10

Open
LiamAttClarke opened this issue Jun 20, 2019 · 1 comment

Comments

@LiamAttClarke
Copy link

If you try to run the app with a contribution amount that contains a comma thousands separator (i.e. 10,000) you will get the following exception:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ParseFloatError { kind: Invalid }', src\libcore\result.rs:997:5
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

The same error occurs if any number within the portfolio.csv or targets.csv has a comma separated number.

Fund A, $40000
Fund B, $40,000 <-- 😢
Fund C, $1000
@dashed
Copy link
Owner

dashed commented Jun 21, 2019

@LiamAttClarke thanks Liam! I'll see if I can add in some sort of currency-like parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants