{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":19352450,"defaultBranch":"develop","name":"dash","ownerLogin":"dashpay","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2014-05-01T17:45:34.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/11511719?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1723033416.0","currentOid":""},"activityList":{"items":[{"before":"6eb6982f414ba9b6abf69dcb96569b90b0e2b0eb","after":"d8fca3840418adf00488d3a448cf3d6b293b99bc","ref":"refs/heads/develop","pushedAt":"2024-08-18T02:28:42.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6208: fix: persist coinjoin denoms options from gui over restarts\n\n3ec0c8ca0a34cf35df4f4431bc282f0b99618d8a fix: persist coinjoin denoms and sessions options from gui over restarts (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Persist coinjoin denoms over restarts, fixes #5975\n\n ## What was done?\n Soft set the argument into the daemon from GUI settings\n\n ## How Has This Been Tested?\n follow procedure in 5975\n\n ## Breaking Changes\n\n ## Checklist:\n _Go over all the following points, and put an `x` in all the boxes that apply._\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n knst:\n utACK 3ec0c8ca0a34cf35df4f4431bc282f0b99618d8a\n UdjinM6:\n utACK 3ec0c8ca0a34cf35df4f4431bc282f0b99618d8a\n\nTree-SHA512: b7378460b3990713b755f36de506b94e7d0005f19cf1155f2fc12191ba03f2e16c35049ddbd89f578acd89bc8eae5e432913114e1ff5ef7ab2cc30628aeff3f2","shortMessageHtmlLink":"Merge #6208: fix: persist coinjoin denoms options from gui over restarts"}},{"before":"7d8a19ef7c7c90fcfe55c299154e6c816eedc048","after":"6eb6982f414ba9b6abf69dcb96569b90b0e2b0eb","ref":"refs/heads/develop","pushedAt":"2024-08-18T02:27:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6210: ci: add more hosts to Github Actions\n\ncb3ac4656b740ae9b8204b9d95e66794620bd012 ci: add more hosts to Github Actions (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Add more linux hosts to GitHub Actions CI. This builds and runs tests (unit) on all these. Functional tests and Mac / Windows should be coming in the future\n\n ## How Has This Been Tested?\n https://github.com/PastaPastaPasta/dash/actions/runs/10364729979\n\n ## Breaking Changes\n None\n\n ## Checklist:\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK cb3ac4656b740ae9b8204b9d95e66794620bd012\n\nTree-SHA512: c9e13d2cf53c12100905bec4b444b9750879733ec42e1f37265c5f2dda416071324c6a181df3fcf35b2a8eeb78ddaf8ed109cbd914be6b2c43916e8feaba25c2","shortMessageHtmlLink":"Merge #6210: ci: add more hosts to Github Actions"}},{"before":"df07c38151673e5cd5ae18750088edc9e8e3e593","after":"7d8a19ef7c7c90fcfe55c299154e6c816eedc048","ref":"refs/heads/develop","pushedAt":"2024-08-18T02:11:54.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6219: fix: correct is_snapshot_cs in VerifyDB\n\nbf377d47e59d9adaca42d5b6df3505e5d3b24fc7 fix: correct is_snapshot_cs in VerifyDB (James O'Beirne)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Flag `is_snapshot_cs` has been inverted in bitcoin#21584\n\n Discovered during investigation of issue:\n ```\n Verifying last 6 blocks at level 3\n 2024-08-14T14:51:55Z [0%]...*** Found EvoDB inconsistency, you must reindex to continue\n ```\n So far as code below does:\n ```\n if ((fPruneMode || is_snapshot_cs) && !(pindex->nStatus & BLOCK_HAVE_DATA)) {\n // If pruning or running under an assumeutxo snapshot, only go\n // back as far as we have data.\n LogPrintf(\"VerifyDB(): block verification stopping at height %d (pruning, no data)\\n\", pindex->nHeight);\n break;\n }\n ```\n In case of missing data in evo db we will get instead of \"block verification stopping at height\" we may get data inconsistency issue.\n\n ## What was done?\n Inverted condition back (same fix in bitcoin/bitcoin#27596)\n\n ## How Has This Been Tested?\n Unit/functional tests doesn't cover it, but they do no fail after fix.\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK bf377d47e59d9adaca42d5b6df3505e5d3b24fc7\n PastaPastaPasta:\n utACK bf377d47e59d9adaca42d5b6df3505e5d3b24fc7\n\nTree-SHA512: ac21e6db6e23c4c7dc150fb16171aef47c9f42c29466b403bca7d56ed6faa2fccc41df92e1fabec4d6e9fd56991e152dea168593a4550fc3583631a63009c27f","shortMessageHtmlLink":"Merge #6219: fix: correct is_snapshot_cs in VerifyDB"}},{"before":"e41615572e2f34fadd9cd3f86eec2c50ac59c2af","after":"df07c38151673e5cd5ae18750088edc9e8e3e593","ref":"refs/heads/develop","pushedAt":"2024-08-14T06:18:38.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6189: backport: bitcoin#16333, #21862, #22385, #22550, #22597, #22632, #22718, #22907 - fire up test chains by first block - 2/n\n\ne4e7c440f48058dabdc571a0a20626b513efd26c fix: use proper chain instead using ActiveChain for test framework (Konstantin Akimov)\n65b92fa09353293f90668b6acab74d61d519af75 Merge bitcoin/bitcoin#21862: test: Set regtest.BIP65Height = 111 to speed up tests (fanquake)\nadcf095ab9013fb3e1bdb01af0b2320b0e3e9ca8 Merge bitcoin/bitcoin#22718: doc: Add missing PR 16333 release note (MarcoFalke)\n101a863399b7564fcd7083d81311b944759490f2 Merge bitcoin/bitcoin#16333: test: Set BIP34Height = 2 for regtest (MarcoFalke)\n71af8816ef726d4da4b051b6a0c9f727e78648a5 Merge bitcoin/bitcoin#22907: test: Avoid intermittent test failure in feature_csv_activation.py (merge-script)\nfc25503cbc866cd027af3c88bc9f235aa827d532 Merge bitcoin/bitcoin#22632: test: Set regtest.BIP66Height = 102 to speed up tests (W. J. van der Laan)\ncbd2be8e18cc41f3e27fd6ce131e4c5e7b60429a Merge bitcoin/bitcoin#22597: consensus/params: simplify ValidDeployment check to avoid gcc warning (MarcoFalke)\n8928146bfa3d9139dace478c76b99a1642167ff5 Merge bitcoin/bitcoin#22550: test: improve `test_signing_with_{csv,cltv}` subtests (speed, prevent timeout) (MarcoFalke)\nfb00431b7c0b55fe2c9630aa07951975d453e0a3 Merge bitcoin/bitcoin#22385: refactor: Use DeploymentEnabled to hide VB deployments (MarcoFalke)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Backports from bitcoin related to hard-fork mechanism and accelerated action\n\n ## What was done?\n see commits for backports.\n Also fixed an issue of using from ChainState on RegTest: should be used specified chain, not the \"best chain\".\n\n ## How Has This Been Tested?\n Run unit & functional tests\n\n ## Breaking Changes\n That's a breaking changes for RegTest\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n PastaPastaPasta:\n utACK e4e7c440f48058dabdc571a0a20626b513efd26c\n\nTree-SHA512: c02813179177781a0da3beaff65732e12017f0056565b897891b2c5a06fda125a4e032571a02fad9d8640728df82c117393bd78bc6d406e0a30f72587b2d7344","shortMessageHtmlLink":"Merge #6189: backport: bitcoin#16333, bitcoin#21862, bitcoin#22385, bβ¦"}},{"before":"792c0320baa067d49b6fdd92d3b1df412331c5a4","after":"e41615572e2f34fadd9cd3f86eec2c50ac59c2af","ref":"refs/heads/develop","pushedAt":"2024-08-13T14:14:49.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6211: fix: use coinstatsindex instead blockfilterindex in feature_prunning\n\n40c0e060473bf228cb79ade626b8030ec01f8e1c fix: use coinstatsindex instead blockfilterindex in feature_prunning (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n\n This is follow-up changes for backports bitcoin#15946 and bitcoin#19521\n\n It fixes failure:\n\n TestFramework (INFO): Test invalid pruning command line options\n TestFramework (ERROR): Assertion failed\n Traceback (most recent call last):\n File \"dashtest/functional/test_framework/test_node.py\", line 511, in assert_start_raises_init_error\n ret = self.process.wait(timeout=self.rpc_timeout)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/usr/lib/python3.11/subprocess.py\", line 1264, in wait\n return self._wait(timeout=timeout)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/usr/lib/python3.11/subprocess.py\", line 2038, in _wait\n raise TimeoutExpired(self.args, timeout)\n subprocess.TimeoutExpired: Command '['dashsrc/dashd', '-datadir=/tmp/dash_func_test_m8w6q7a2/node0', '-logtimemicros', '-debug', '-debugexclude=libevent', '-debugexclude=leveldb', '-mocktime=1417713337', '-uacomment=testnode0', '-logthreadnames', '-logsourcelocations', '-createwalletbackups=0', '-prune=550', '-blockfilterindex', '-mocktime=1417713337']' timed out after 120 seconds\n\n During handling of the above exception, another exception occurred:\n\n Traceback (most recent call last):\n File \"dashtest/functional/test_framework/test_framework.py\", line 159, in main\n self.run_test()\n File \"dashtest/functional/feature_pruning.py\", line 495, in run_test\n self.test_invalid_command_line_options()\n File \"dashtest/functional/feature_pruning.py\", line 149, in test_invalid_command_line_options\n self.nodes[0].assert_start_raises_init_error(\n File \"dashtest/functional/test_framework/test_node.py\", line 541, in assert_start_raises_init_error\n self._raise_assertion_error(assert_msg)\n File \"dashtest/functional/test_framework/test_node.py\", line 180, in _raise_assertion_error\n raise AssertionError(self._node_msg(msg))\n AssertionError: [node 0] dashd should have exited within 120s with expected error Error: Prune mode is incompatible with -blockfilterindex.\n TestFramework (INFO): Stopping nodes\n\n ## What was done?\n Removed `blockfilterindex` test, enabled `coinstatsindex` test.\n\n ## How Has This Been Tested?\n Run manually: `test/functional/feature_pruning.py`\n This test is not run by our CI\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n PastaPastaPasta:\n utACK 40c0e060473bf228cb79ade626b8030ec01f8e1c\n UdjinM6:\n ACK 40c0e060473bf228cb79ade626b8030ec01f8e1c\n\nTree-SHA512: 94005c52a39cc02be8df65898844584fb247b71abab36341c3d8b4e5018902931ed8554734f27bb5d54fae2b7867ba40f136fc089fd6f9f0e57852203a5d4011","shortMessageHtmlLink":"Merge #6211: fix: use coinstatsindex instead blockfilterindex in featβ¦"}},{"before":"6ef28ca493894b5ec4f2ade789411c1d771a6ad1","after":"792c0320baa067d49b6fdd92d3b1df412331c5a4","ref":"refs/heads/develop","pushedAt":"2024-08-13T14:13:02.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6206: fix: 6205 follow-up\n\n52b9fcecb4f28a91658262a52cee36631586b2be fix: can't mix `-` and `:` (UdjinM6)\n2f12f91d395a45eddb2090145ed707cbc39c7bce fix: 6205 follow-up (UdjinM6)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n I think I messed up whitespaces so these jobs can't run now, they fail with `[Error] Invalid type for on` https://github.com/dashpay/dash/actions/runs/10353281487...\n Weird that they succeeded in #6205 https://github.com/dashpay/dash/actions/runs/10352521500/workflow https://github.com/dashpay/dash/actions/runs/10352521490/workflow π€·ββοΈ\n\n ## What was done?\n\n ## How Has This Been Tested?\n\n ## Breaking Changes\n\n ## Checklist:\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n PastaPastaPasta:\n utACK 52b9fcecb4f28a91658262a52cee36631586b2be\n\nTree-SHA512: f4dff14b727164c5a79545dc2650dc716eb08ddb6445d76fc70a3bdc5044d22212ce44fd942db65559154e989c0ff272d733558b1773440a88a691a222642746","shortMessageHtmlLink":"Merge #6206: fix: 6205 follow-up"}},{"before":"60403ef207db9ccc949744298bf97769ba8ae30e","after":"6ef28ca493894b5ec4f2ade789411c1d771a6ad1","ref":"refs/heads/develop","pushedAt":"2024-08-13T14:06:14.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6158: backport: trivial 2024 07 25\n\n0dd997c4e565e81d20de0a04354a3fd361b4ec78 Merge bitcoin/bitcoin#26835: contrib: add PE Canary check to security-check (fanquake)\nb6bde7322c5a80795f2d3f86ee68c382247d70e7 Merge bitcoin/bitcoin#26827: doc: use \"std lib clock\" over \"C++11 clock\" (MarcoFalke)\n93c4652a0578cb2cf0363410617392a405b534d4 Merge bitcoin/bitcoin#26821: refactor: Make `ThreadHTTP` return void (Andrew Chow)\n07f4c39c44ab1c16dd978ba9ce4f86fefe6905a2 Merge bitcoin/bitcoin#26730: test: add coverage for `purpose` arg in `listlabels` (MarcoFalke)\n6fe46fc02af626375e735655c4f1cf06a4ab40fb Merge bitcoin/bitcoin#26864: doc: net: fix link to onion address encoding scheme [ONIONADDRESS] (MarcoFalke)\nd1b93c78b7f49a69190dc5e00afad8313ce0eaf0 Merge bitcoin/bitcoin#26818: test: Fix feature_startupnotify intermittent issue (MarcoFalke)\n864d02e4a96fb4e33f8e719354214d6c1ba21114 Merge bitcoin/bitcoin#26809: compat: use STDIN_FILENO over 0 (Andrew Chow)\n092ddc3a3e1d55bf957596f63a9e0dbd9ca3ce21 Merge bitcoin/bitcoin#26603: doc: CalculateSequenceLocks: prevHeights entries are set to 0, not removed (glozow)\n7f2b9340899a53739a45ee9b66438e5a0321ca63 Merge bitcoin/bitcoin#26772: contrib: fix sha256 check in install_db4.sh for FreeBSD (fanquake)\ndf2f533aaf6db2f2054e2d7e9e811c5b3d077ba5 Merge bitcoin/bitcoin#26759: test: Drop no longer needed `race:epoll_ctl` TSan suppression (MarcoFalke)\n959092990016e9d0dbb18d524eee8b9191e5d87b Merge bitcoin/bitcoin#24944: rpc: add getblockfrompeer RPCTypeCheck and invalid input test coverage (MacroFake)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Trivial backports; need to see ci pass\n\n ## What was done?\n\n ## How Has This Been Tested?\n built\n\n ## Breaking Changes\n\n ## Checklist:\n _Go over all the following points, and put an `x` in all the boxes that apply._\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n knst:\n utACK 0dd997c4e565e81d20de0a04354a3fd361b4ec78\n UdjinM6:\n utACK 0dd997c4e565e81d20de0a04354a3fd361b4ec78\n\nTree-SHA512: e23207508dfc88a961e0eed031b1c6d195469d61343f0d1c66be853a6fcd882a84d8d40670c263264fe96c9a8a98d83fc0f0a05c263eadc64056edb563c588db","shortMessageHtmlLink":"Merge #6158: backport: trivial 2024 07 25"}},{"before":"8f7dd9c6d230453d5aba30fec2310c649f7faf1d","after":"60403ef207db9ccc949744298bf97769ba8ae30e","ref":"refs/heads/develop","pushedAt":"2024-08-13T06:16:05.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6159: backport: bitcoin#20773, #21169, #21798, #21810, #21892, #21922, #21931, #22004\n\n9ad26f1664821804aeed9b82d055093cc078c143 fix: follow-up bitcoin#20773 - coinjoin loader can be nullptr too (Konstantin Akimov)\n4125485401ac74e3473776fd9b152aa1a8c0ea26 fix: follow-up bitcoin#20773 - for collateral lock/unlock coins (Konstantin Akimov)\n06ea87040b8d90c6376475c8de0182d155552ec1 Merge bitcoin/bitcoin#20773: refactor: split CWallet::Create (W. J. van der Laan)\nd89847f43e813ce873db8471f5360c7f49e265b9 Merge bitcoin/bitcoin#22004: fuzz: Speed up transaction fuzz target (MarcoFalke)\n82a6aa590780dfe2159ab2add1c7f3be5484c111 Merge bitcoin/bitcoin#21810: fuzz: Various RPC fuzzer follow-ups (MarcoFalke)\n3bfefde53b6de019cb8382ecd160ecd1536a2bf6 Merge bitcoin/bitcoin#21931: ci: Bump cirrus fuzz CPUs to avoid timeout (MarcoFalke)\n2398283ff6f1174dfdf1c32f14f72632d4781514 Merge bitcoin/bitcoin#21922: fuzz: Avoid timeout in EncodeBase58 (fanquake)\n813993d44ae6152249acd7604674539bbf0c1fcf Merge bitcoin/bitcoin#21892: fuzz: Avoid excessively large min fee rate in tx_pool (MarcoFalke)\n4dd36f603a82e4a9885de70d2969529c527ada66 Merge bitcoin/bitcoin#21798: fuzz: Create a block template in tx_pool targets (MarcoFalke)\nc2bd834f3b127295bcbebcdaf98122f577a24658 Merge bitcoin/bitcoin#21169: fuzz: Add RPC interface fuzzing. Increase fuzzing coverage from 65% to 70%. (MarcoFalke)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Regular backports from bitcoin v22\n\n ## What was done?\n see commits\n\n ## How Has This Been Tested?\n Run unit/functional tests\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nTop commit has no ACKs.\n\nTree-SHA512: 5d2cca761bb7971b3d83f1b54a5c26d62c9495becdf6d897e22bfd975837605bb5326dc37793f838389c9145db34ef45992be95e789af8c12af9b6ade79a0038","shortMessageHtmlLink":"Merge #6159: backport: bitcoin#20773, bitcoin#21169, bitcoin#21798, bβ¦"}},{"before":"25eef1e8cabacbf251f5c83bd9d1934bc804808e","after":"8f7dd9c6d230453d5aba30fec2310c649f7faf1d","ref":"refs/heads/develop","pushedAt":"2024-08-12T13:26:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6205: fix: only run some GH actions on PR approval, not on every comment\n\n2777d30caa3e69c7d06475a0fa72fe3216ae685a fix(ci): only run some GH actions on PR approval, not on every comment (UdjinM6)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-a-workflow-when-a-pull-request-is-approved\n\n ## What was done?\n\n ## How Has This Been Tested?\n\n ## Breaking Changes\n\n ## Checklist:\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n PastaPastaPasta:\n utACK 2777d30caa3e69c7d06475a0fa72fe3216ae685a\n\nTree-SHA512: 183deae1d1b32408bd81962721141e976912b2614a046ab23565537db62fcff7d367331db8ced7cf176dc67adbc18b96e7678b37068f807aaafb1718d55dea70","shortMessageHtmlLink":"Merge #6205: fix: only run some GH actions on PR approval, not on eveβ¦"}},{"before":"23d84c6d922bd5a10d41e8ecc01c805fe05c71ab","after":"25eef1e8cabacbf251f5c83bd9d1934bc804808e","ref":"refs/heads/develop","pushedAt":"2024-08-12T11:47:33.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6199: fix: compile error due to rebase mistake between bitcoin#22937 and ipc/process\n\n540f6871d3acdfc7c890cbc9d61d4cd9b3add974 fix: lock `::cs_main` before accessing `ChainstateManager::m_best_header` (Kittywhiskers Van Gogh)\naafded67d97c5459ff4d2846ed9417dc4292015a fix: compilation error due to rebase error between bitcoin#22937 and ipc/process (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n CI failure for multiprocess\n\n ## What was done?\n It resolve compilation failure on develop (apply changes from 22937 to ipc/process)\n\n See alternate solutions:\n - https://github.com/dashpay/dash/pull/6192\n - https://github.com/dashpay/dash/pull/6195\n\n ## How Has This Been Tested?\n Run build locally:\n ```\n make MULTIPROCESS=1 -j10\n ./configure --prefix=$(pwd)/depends/x86_64-pc-linux-gnu --enable-suppress-external-warnings --enable-werror --enable-debug --enable-crash-hooks --enable-maintainer-mode --enable-stacktraces --enable-multi-process\n ```\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n PastaPastaPasta:\n utACK 540f6871d3acdfc7c890cbc9d61d4cd9b3add974\n\nTree-SHA512: 75b675e93763e8e53086a10b93516b8ec94418902f9be2de738517176cc835c0dad25c286426089a5327a9c13d1787b89debda2c6025cb598489204d7d5af2cf","shortMessageHtmlLink":"Merge #6199: fix: compile error due to rebase mistake between bitcoinβ¦"}},{"before":"41a67dcca85e9bdd4acef1f362d05fdb2ea2cefc","after":"23d84c6d922bd5a10d41e8ecc01c805fe05c71ab","ref":"refs/heads/develop","pushedAt":"2024-08-12T10:37:39.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6190: feat: improve merge-check action to leave a comment and label to PRs\n\n5394d63e18a8d6c5d6747147e6572bc08228812e feat: improve merge-check action to leave a comment and label to PRs (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n this is untested but I think it'll work, simply add comment and label to PRs which fail this CI\n\n ## What was done?\n\n ## How Has This Been Tested?\n hasn't but if this action breaks that is not critical\n\n ## Breaking Changes\n None\n\n ## Checklist:\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK 5394d63e18a8d6c5d6747147e6572bc08228812e\n\nTree-SHA512: 78ae7c05446a0625143fb7e04b7e63ae0830ca45cde4f924eb4e04dfb12ac3cc9e697efbd914a71a9b5ba98400597e7559258b5d93419ed7eb7cc14a9b876fe7","shortMessageHtmlLink":"Merge #6190: feat: improve merge-check action to leave a comment and β¦"}},{"before":"bc73522601545a891d462f0bdcacaaec037f65c1","after":"41a67dcca85e9bdd4acef1f362d05fdb2ea2cefc","ref":"refs/heads/develop","pushedAt":"2024-08-12T10:26:06.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6197: ci: always build guix, save artifacts\n\n770651aa157c2412b96e38fd8ee56a33e8c292bc set hosts in guix-check (pasta)\n580bbe6d1c3d4b6229d20e69978e5eeebac845a5 feat: improve guix building; run always, save artifacts (pasta)\n101a31555fbe039113c55ec641ec9f1d4121abf2 refactor: simplify caching setup, add a restore key to actually cache besides 1 run (pasta)\n1b139e4837b9bc3167028def245522df75f18ae3 feat: automatically run guix-build on all tags pushed (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Previously, we only ran guix on 1 machine for all hosts; this slowed it down a lot. Let's move to GitHub action runners, but run them all separately. Then upload the artifacts.\n\n In the future there is significant caching I can add that should help a lot more. But currently, takes about 1 hour\n\n ## What was done?\n\n ## How Has This Been Tested?\n see: https://github.com/PastaPastaPasta/dash/actions/runs/10345024600\n\n ## Breaking Changes\n None\n\n ## Checklist:\n _Go over all the following points, and put an `x` in all the boxes that apply._\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK 770651aa157c2412b96e38fd8ee56a33e8c292bc\n\nTree-SHA512: 639b95c3b6a26f205ed00c138a9189f915cfc36a815516035e59ceda82675414b1bd31a361b33449b5e4c58a7655f3a7d616b362c23f7fa75e72b1284be06b9e","shortMessageHtmlLink":"Merge #6197: ci: always build guix, save artifacts"}},{"before":"de4e7e16b45a487e8f48ac83d5bada02a846e54e","after":"bc73522601545a891d462f0bdcacaaec037f65c1","ref":"refs/heads/develop","pushedAt":"2024-08-12T10:17:00.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6196: refactor: use `=` with ENV in dockerfiles\n\n92f82f6fc65ff4dbfa4ddb396c8354c7bc808f52 fix: group the ENV in quotations (pasta)\n2237b4266b76956c8f8f20cee42256b19493e03f refactor: use `=` with ENV in dockerfiles (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n see: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/\n\n Basically avoid old format of ENV in docker files\n\n ## What was done?\n see commit\n\n ## How Has This Been Tested?\n Building the containers locally, seems all fine\n\n ## Breaking Changes\n _Please describe any breaking changes your code introduces_\n\n ## Checklist:\n _Go over all the following points, and put an `x` in all the boxes that apply._\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n knst:\n utACK 92f82f6fc65ff4dbfa4ddb396c8354c7bc808f52\n UdjinM6:\n utACK 92f82f6fc65ff4dbfa4ddb396c8354c7bc808f52\n\nTree-SHA512: 0fb5028b9fd8e8f2cac6d7488c3254f58a9ee96f2c236a1d0b90ea48f57b793be3caab6fc764b4ac1127eada9fae85468a13d2eb2a1c3e0a6940a6c8bc601681","shortMessageHtmlLink":"Merge #6196: refactor: use = with ENV in dockerfiles"}},{"before":"efe4c2d6eb7bbbaf0e385790a45f61686cd4ee9b","after":"de4e7e16b45a487e8f48ac83d5bada02a846e54e","ref":"refs/heads/develop","pushedAt":"2024-08-11T09:26:17.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6171: feat: implement GitHub Actions based starter CI\n\nacf1315270b483c0f3e08948fa0295f99d9e836c Merge bitcoin/bitcoin#25091: test: Remove extended lint (cppcheck) (MacroFake)\n4dbdecdd1e466a5a25681a1e382dc75190580754 refactor: rename builder-image -> build-image and builder as image name to dashcore-ci-runner (pasta)\ned8ffa7fb46ece8f593811e59699b2aed7228fd8 feat: have cppcheck linter respect CACHE_DIR env variable (pasta)\nd1addb27aa147b59bd54331317b009977a4844ac fix: change fallback download path to be an s3 link which includes a few packages (pasta)\n35c76705d13727f01aa8507fbdd1d0584bd9ecef feat: implement basic Github Actions based CI, which reuses underlying logic from GitLab CI (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n We currently rely on GitLab for running CI, and while it has worked quite well, I am worried about having all of our eggs in one basket! As such, I've long wanted to explore implemeenting Github Actions based CI, but was too lazy! Well I finally spent some 60 commits trying to figure everything out, and this PR is the result of it.\n\n As a result, we will now have two semi-redunant CI systems, the primary one on GitLab, and this one on Github Actions. Currently the GA based CI will only do one host, and does linting. Be aware this GA based CI does not actually run the tests, it does build depends, src and run linters on 1 host.\n In the future, we should expand it from simply arm32 builds to having feature parity to GitLab.\n\n While it appears the GA default runners are a bit slower than what we have on GitLab, there's a big difference, the GA runners are free :D If we decide to make the GA based CI primary, we'll probably want to setup some custom runners to have improved build speeds. Even still, a heavily cached build doing all linters took around 5 minutes if I recall correctly. Without caches I think it took maybe an hour, so defenitely not bad.\n\n ## What was done?\n See the individual commits, they're pretty self explanatory\n\n ## How Has This Been Tested?\n Lots of CI runs on my prior branch :) CI should run on this PR, and we should see how long it'll take w/o cache :D\n\n ## Breaking Changes\n N/A - CI only\n\n ## Checklist:\n _Go over all the following points, and put an `x` in all the boxes that apply._\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation\n - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nTop commit has no ACKs.\n\nTree-SHA512: fef41d1b73fdeac29e5096ffa7fa26660efc44ac274376d5880b5fabf6b0e760aeda4a4ae9c24656ee0e3adb760459f0d45b955cefffc9d0eeb5384afbc9d473","shortMessageHtmlLink":"Merge #6171: feat: implement GitHub Actions based starter CI"}},{"before":"7cc99c43c387699c9c5d27c00de0595a9aee48b2","after":"efe4c2d6eb7bbbaf0e385790a45f61686cd4ee9b","ref":"refs/heads/develop","pushedAt":"2024-08-10T12:15:32.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6143: backport: bitcoin#19160, #21663, #21669, #21732, #21738, #21750, #21775, #21812\n\nf4cb0fbfe10b070eee36a2a6833a705aaf533ce0 fix: no need to relay quorum commitment in case of block undo (Konstantin Akimov)\n0431a33919e72c72c851a1137b3a6e9840f8bee3 fix: follow-up changes for bitcoin#14193. (Konstantin Akimov)\n86b76d19b6a495578781faba13fedbfaa7ec3f2e Merge bitcoin/bitcoin#21812: ci: Enable D_GLIBCXX_DEBUG for multiprocess task (fanquake)\n334496ea7eea0735e5d354bc2756d5cc4b63cd19 Merge bitcoin/bitcoin#21775: p2p: Limit m_block_inv_mutex (MarcoFalke)\n23b83109eaacb64872be21b460b1bc8758cb4fd2 Merge bitcoin/bitcoin#21750: net: remove unnecessary check of CNode::cs_vSend (MarcoFalke)\nb34514191f9fd8233552c45512070129c3ca9caa Merge bitcoin/bitcoin#21738: test: Use clang-12 for ASAN, Add missing suppression (fanquake)\n3411577473296f7a145bf02f238be62e840707c6 Merge bitcoin/bitcoin#19160: multiprocess: Add basic spawn and IPC support (W. J. van der Laan)\n970048d9173bb017ee57b003557f81c051ff4f06 fix: missing changes from bitcoin#19267 - run multiprocess on CI (Konstantin Akimov)\nf2b7ee73dbf7ec126a5aa526ff74a220480e79c6 fix: follow-up bitcoin#15402 - removed dead code (Konstantin Akimov)\n274068cdbcbd4e9cfffc2475bfa20edef8fa3111 fix: follow-up bitcoin/bitcoin#21732 - minor missing typo (MarcoFalke)\ne9450a8b368db16f033bb13bee4c0f5830133b80 Merge #21669: test: Remove spurious double lock tsan suppressions by bumping to clang-12 (MarcoFalke)\nef92c3065cab1e5361d6f9161e5f7b376c3978fa Merge #21663: ci: Fix macOS brew install command (W. J. van der Laan)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Just regular backports from v22\n\n ## What was done?\n See commits for backports.\n\n Also there're 2 bugs are fixed which became visible after backporting bitcoin#21775 - both are related to possible deadlocks in net_processing\n\n ## How Has This Been Tested?\n Run unit and functional tests. Enabled multiprocess builds on CI\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK f4cb0fbfe10b070eee36a2a6833a705aaf533ce0\n PastaPastaPasta:\n utACK f4cb0fbfe10b070eee36a2a6833a705aaf533ce0\n\nTree-SHA512: 3204c2aa243fa4834ccf4ff4672d183cf9b35f87b857df8543572cd685729e15fca39f85b27194233e57cbc1746e36b556efab95ce20d0aa0a7d4476a9f3c6c0","shortMessageHtmlLink":"Merge #6143: backport: bitcoin#19160, bitcoin#21663, bitcoin#21669, bβ¦"}},{"before":"117dda9d6fecba585200ae557de37def8afb4caf","after":"7cc99c43c387699c9c5d27c00de0595a9aee48b2","ref":"refs/heads/develop","pushedAt":"2024-08-10T11:57:22.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6188: fix: help p2p_timeouts to succeed on the my localhost\n\n92834d1ef2042b91dd1558257018221d16e69df0 fix: help p2p_timeouts to succeed on the my localhost (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Locally on my environment the functional tests `p2p_timeouts.py` fails in 80% runs.\n\n Output:\n ```\n stdout:\n 2024-08-08T05:02:32.216000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_β_π_20240808_120217/p2p_timeouts_0\n 2024-08-08T05:02:35.079000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''\n def test_function():\n if check_connected:\n assert self.is_connected\n return test_function_in()\n '''\n 2024-08-08T05:02:35.080000Z TestFramework (ERROR): Assertion failed\n Traceback (most recent call last):\n File \"DASH/test/functional/test_framework/test_framework.py\", line 159, in main\n self.run_test()\n File \"DASH/test/functional/p2p_timeouts.py\", line 93, in run_test\n no_verack_node.wait_for_disconnect(timeout=1)\n File \"DASH/test/functional/test_framework/p2p.py\", line 495, in wait_for_disconnect\n self.wait_until(test_function, timeout=timeout, check_connected=False)\n File \"DASH/test/functional/test_framework/p2p.py\", line 487, in wait_until\n wait_until_helper(test_function, timeout=timeout, lock=p2p_lock, timeout_factor=self.timeout_factor)\n File \"DASH/test/functional/test_framework/util.py\", line 267, in wait_until_helper\n raise AssertionError(\"Predicate {} not true after {} seconds\".format(predicate_source, timeout))\n AssertionError: Predicate ''''\n def test_function():\n if check_connected:\n assert self.is_connected\n return test_function_in()\n ''' not true after 1.0 seconds\n 2024-08-08T05:02:35.581000Z TestFramework (INFO): Stopping nodes\n 2024-08-08T05:02:36.582000Z TestFramework (WARNING): Not cleaning up dir /tmp/test_runner_β_π_20240808_120217/p2p_timeouts_0\n 2024-08-08T05:02:36.582000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/test_runner_β_π_20240808_120217/p2p_timeouts_0/test_framework.log\n 2024-08-08T05:02:36.582000Z TestFramework (ERROR):\n 2024-08-08T05:02:36.582000Z TestFramework (ERROR): Hint: Call DASH/test/functional/combine_logs.py '/tmp/test_runner_β_π_20240808_120217/p2p_timeouts_0' to consolidate all logs\n 2024-08-08T05:02:36.582000Z TestFramework (ERROR):\n 2024-08-08T05:02:36.582000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.\n 2024-08-08T05:02:36.582000Z TestFramework (ERROR): https://github.com/dashpay/dash/issues\n 2024-08-08T05:02:36.582000Z TestFramework (ERROR):\n\n stderr:\n\n TEST | STATUS | DURATION\n\n p2p_timeouts.py | β Passed | 4 s\n p2p_timeouts.py | β Failed | 4 s\n p2p_timeouts.py | β Failed | 5 s\n p2p_timeouts.py | β Failed | 5 s\n p2p_timeouts.py | β Failed | 6 s\n p2p_timeouts.py | β Failed | 6 s\n p2p_timeouts.py | β Failed | 7 s\n\n ALL | β Failed | 37 s (accumulated)\n Runtime: 7 s\n ```\n\n ## What was done?\n Increased a timeout to see for first disconnect event +1 second.\n\n ## How Has This Been Tested?\n 100% succeed:\n ```\n $ test/functional/test_runner.py -j20 p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py p2p_timeouts.py\n\n p2p_timeouts.py | β Passed | 4 s\n p2p_timeouts.py | β Passed | 5 s\n p2p_timeouts.py | β Passed | 5 s\n p2p_timeouts.py | β Passed | 6 s\n p2p_timeouts.py | β Passed | 6 s\n p2p_timeouts.py | β Passed | 7 s\n p2p_timeouts.py | β Passed | 7 s\n p2p_timeouts.py | β Passed | 8 s\n p2p_timeouts.py | β Passed | 8 s\n p2p_timeouts.py | β Passed | 9 s\n p2p_timeouts.py | β Passed | 9 s\n p2p_timeouts.py | β Passed | 10 s\n p2p_timeouts.py | β Passed | 10 s\n p2p_timeouts.py | β Passed | 11 s\n p2p_timeouts.py | β Passed | 11 s\n p2p_timeouts.py | β Passed | 12 s\n ```\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n ACK 92834d1ef2042b91dd1558257018221d16e69df0\n PastaPastaPasta:\n utACK 92834d1ef2042b91dd1558257018221d16e69df0\n\nTree-SHA512: 598178fd97e82def16b32cbaf1f476d3416768456a7f92fb4faadc041b73147cc7be3e6760287bde22d1a3e5a5a9190124ede6da81a1722feba1e80fcc3ae4e3","shortMessageHtmlLink":"Merge #6188: fix: help p2p_timeouts to succeed on the my localhost"}},{"before":"e803b320d6ab32abea7fe107dd3c4b0ba3c3e34c","after":"117dda9d6fecba585200ae557de37def8afb4caf","ref":"refs/heads/develop","pushedAt":"2024-08-09T10:43:17.000Z","pushType":"push","commitsCount":14,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6097: backport: merge bitcoin#24024, #23880, #24909, #24178, #24171, #25404, #25514, #25720, partial bitcoin#23832, #24169, #25454 (headers backports)\n\nc92b0f57da7f4926299f0bb68c0d82ffb7f7e3f6 merge bitcoin#25720: Reduce bandwidth during initial headers sync when a block is found (Kittywhiskers Van Gogh)\n0f9ece0ed9e98a13dae8179d5316539c8478677a merge bitcoin#25514: Move CNode::nServices and CNode::nLocalServices to Peer (Kittywhiskers Van Gogh)\nc9923ca36b7804a871f051f0e5ee116a2ed89007 partial bitcoin#25454: Avoid multiple getheaders messages in flight to the same peer (Kittywhiskers Van Gogh)\n26d477b6ae7aa1fa0e59891096ef1f62c103455d revert: Fix duplicate initial headers sync (Kittywhiskers Van Gogh)\nabccb2dd03ffb70a4757889d4b78ac8515226962 test: drop genesis block from `blockheader_testnet3` (Kittywhiskers Van Gogh)\n0574a7d19e1cdb31048ffb261dd1cc9a72918d10 merge bitcoin#25404: Use MAX_BLOCKS_TO_ANNOUNCE consistently (Kittywhiskers Van Gogh)\ned871d2a079cc6cde18870a703faea07db3cf772 merge bitcoin#24171: Sync chain more readily from inbound peers during IBD (Kittywhiskers Van Gogh)\na04290fc5c1fcf20fc4e06a6710bff473661a4b8 merge bitcoin#24178: Respond to getheaders if we have sufficient chainwork (Kittywhiskers Van Gogh)\nbcafa282a362b17e059293abb6a66b48efec50c5 merge bitcoin#24909: Move and rename pindexBestHeader, fHavePruned (Kittywhiskers Van Gogh)\n70485cb2f5daaea5239dad488dbc1c7f8d5197b5 partial bitcoin#24169: Add --enable-c++20 option (Kittywhiskers Van Gogh)\n27e885de5f31042d431e3b716e819751e36e781d merge bitcoin#23880: Serialize cmpctblock at most once in NewPoWValidBlock (Kittywhiskers Van Gogh)\n9f7ac69a7e800d57c06fb2b6f0e5351aad91474e merge bitcoin#24024: Remove cs_main lock annotation from ChainstateManager.m_blockman (Kittywhiskers Van Gogh)\n9399f90a1331a2ab1bb957ee799af6ceab14a681 partial bitcoin#23832: Changes time variables from int to chrono (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n * Dependent on https://github.com/dashpay/dash/pull/6085\n\n * Dependency for https://github.com/dashpay/dash/pull/6098\n\n * ~~[bitcoin#25514](https://github.com/bitcoin/bitcoin/pull/25514) removes `peers.spvNodeConnections` and `peers.fullNodeConnections` reporting from `CalculateNumConnectionsChangedStats` as the services flags used to distingush between the two have been moved to the `Peer` struct, accessable only through `PeerManager`.~~\n\n ~~As `PeerManager` isn't accessable to `CConnman`, even if a new public function was exposed through `PeerManger` (as we have for `IsInvInFilter` and others or we try to access the value through `GetNodeStateStats`), `CConnman` would be unable to leverage it.~~ Resolved with patch by UdjinM6, thanks!\n\n * [bitcoin#23880](https://github.com/bitcoin/bitcoin/pull/23880) introduces code that is not valid C++20 (but valid C++17) and therefore, required a partial backport of [bitcoin#24169](https://github.com/bitcoin/bitcoin/pull/24169) (fae679065e4ef0c6383bbdd1876aaed6c1e40104) to make the code C++20 legal.\n\n * [bitcoin#25454](https://github.com/bitcoin/bitcoin/pull/25454) introduces a 10-point penalty for remitting more than `MAX_BLOCKS_TO_ANNOUNCE` unconnected block headers. `blockheader_testnet3.hex` (introduced in [bitcoin#16551](https://github.com/bitcoin/bitcoin/pull/16551), part of [dash#5963](https://github.com/dashpay/dash/pull/5963)), unlike in Bitcoin, includes the genesis block.\n\n By definition of a genesis block, there is no block before it that connects to, which causes the 10-point penalty to trip and `p2p_dos_header_tree.py` to fail (see below). This has been remedied by removing the genesis block from the test data to match upstream and also because no node has a good reason to ever broadcast the genesis block as-is over P2P.\n\n \n\n Test Failure
\n\n ```\n dash@6a2649cc721f:/src/dash$ ./test/functional/p2p_dos_header_tree.py\n 2024-06-17T17:59:35.874000Z TestFramework (INFO): Initializing test directory /tmp/dash_func_test_h5hfluy1\n 2024-06-17T17:59:36.892000Z TestFramework (INFO): Read headers data\n 2024-06-17T17:59:36.895000Z TestFramework (INFO): Feed all non-fork headers, including and up to the first checkpoint\n 2024-06-17T17:59:38.411000Z TestFramework (ERROR): Assertion failed\n Traceback (most recent call last):\n File \"/src/dash/test/functional/test_framework/test_framework.py\", line 158, in main\n self.run_test()\n File \"./test/functional/p2p_dos_header_tree.py\", line 53, in run_test\n assert {\n AssertionError\n 2024-06-17T17:59:38.913000Z TestFramework (INFO): Stopping nodes\n 2024-06-17T17:59:39.917000Z TestFramework (WARNING): Not cleaning up dir /tmp/dash_func_test_h5hfluy1\n 2024-06-17T17:59:39.917000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/dash_func_test_h5hfluy1/test_framework.log\n 2024-06-17T17:59:39.917000Z TestFramework (ERROR):\n 2024-06-17T17:59:39.917000Z TestFramework (ERROR): Hint: Call /src/dash/test/functional/combine_logs.py '/tmp/dash_func_test_h5hfluy1' to consolidate all logs\n 2024-06-17T17:59:39.917000Z TestFramework (ERROR):\n 2024-06-17T17:59:39.917000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.\n 2024-06-17T17:59:39.917000Z TestFramework (ERROR): https://github.com/dashpay/dash/issues\n 2024-06-17T17:59:39.917000Z TestFramework (ERROR):\n ```\n\n \n\n * [bitcoin#25454](https://github.com/bitcoin/bitcoin/pull/25454) has a goal similar to [dash#2032](https://github.com/dashpay/dash/pull/2032) (and its predecessor, [dash#1589](https://github.com/dashpay/dash/pull/1589)), namely, avoiding `getheaders`(`2`) duplication to the same peer. Unfortunately, Dash's mitigation seems to conflict with Bitcoin's mitigation and this results in `feature_minchainwork.py` failing (see below). This has been remedied by partially reverting [dash#2032](https://github.com/dashpay/dash/pull/2032).\n\n \n\n Test Failure
\n\n ```\n dash@1bebec413839:/src/dash$ ./test/functional/feature_minchainwork.py\n 2024-08-01T17:29:41.116000Z TestFramework (INFO): Initializing test directory /tmp/dash_func_test_co8xkx43\n 2024-08-01T17:29:42.145000Z TestFramework (INFO): Testing relay across node 1 (minChainWork = 101)\n 2024-08-01T17:29:42.145000Z TestFramework (INFO): Generating 49 blocks on node0\n [...]\n 2024-08-01T17:29:51.707000Z TestFramework (INFO): Generating one more block\n 2024-08-01T17:29:51.709000Z TestFramework (INFO): Verifying nodes are all synced\n 2024-08-01T17:30:51.989000Z TestFramework (ERROR): Assertion failed\n Traceback (most recent call last):\n File \"/src/dash/test/functional/test_framework/test_framework.py\", line 159, in main\n self.run_test()\n File \"./test/functional/feature_minchainwork.py\", line 101, in run_test\n self.sync_all()\n File \"/src/dash/test/functional/test_framework/test_framework.py\", line 811, in sync_all\n self.sync_blocks(nodes)\n File \"/src/dash/test/functional/test_framework/test_framework.py\", line 777, in sync_blocks\n raise AssertionError(\"Block sync timed out after {}s:{}\".format(\n AssertionError: Block sync timed out after 60s:\n '00ab061e30aebd2f97153d26cd72f921af896f05c6469ad73c7de4fc283d9590'\n '00ab061e30aebd2f97153d26cd72f921af896f05c6469ad73c7de4fc283d9590'\n '000008ca1832a4baf228eb1553c03d3a2c8e02399550dd6ea8d65cec3ef23d2e'\n 2024-08-01T17:30:52.490000Z TestFramework (INFO): Stopping nodes\n 2024-08-01T17:30:53.495000Z TestFramework (WARNING): Not cleaning up dir /tmp/dash_func_test_co8xkx43\n 2024-08-01T17:30:53.495000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/dash_func_test_co8xkx43/test_framework.log\n 2024-08-01T17:30:53.495000Z TestFramework (ERROR):\n 2024-08-01T17:30:53.495000Z TestFramework (ERROR): Hint: Call /src/dash/test/functional/combine_logs.py '/tmp/dash_func_test_co8xkx43' to consolidate all logs\n 2024-08-01T17:30:53.495000Z TestFramework (ERROR):\n 2024-08-01T17:30:53.495000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.\n 2024-08-01T17:30:53.495000Z TestFramework (ERROR): https://github.com/dashpay/dash/issues\n 2024-08-01T17:30:53.495000Z TestFramework (ERROR):\n ```\n\n \n\n * [bitcoin#25720](https://github.com/bitcoin/bitcoin/pull/25720) introduces a new test, `p2p_initial_headers_sync.py`, to validate that when a client has a stale tip, it will only engage in headers sync with one peer (emit a `getheaders2`\\* message).\n\n Unmodified, this test fails (see below) as while the backport deals with one source of `getheaders2` messages, the test setup unwittingly triggers another ([source](https://github.com/dashpay/dash/blob/2379462294da884d925b5a80acec20fbc360309f/src/net_processing.cpp#L5446-L5448)), specifically, allowing the `pindexBestHeader->GetBlockTime() > GetAdjustedTime() - nMaxTipAge` condition to evaluate `true`.\n\n This is because, unlike in Bitcoin test suite's `setup_chain()` ([source](https://github.com/bitcoin/bitcoin/blob/22d96d76ab02fc73e7fe0d810bacee4c982df085/test/functional/test_framework/test_framework.py#L379-L385)), Dash sets the mocktime to match the mock chain ([source](https://github.com/dashpay/dash/blob/2379462294da884d925b5a80acec20fbc360309f/test/functional/test_framework/test_framework.py#L408-L416)) during setup, while the test assumes that the mock chain is stale enough to not trigger this source of `getheaders2` messages.\n\n As the tip is barely stale, it emits the `getheaders2` message, which is detected, causing the test to fail. This has been remedied by overriding `setup_chain()` to behave more like Bitcoin's test suite.\n\n _\\* - `getheaders2` is a Dash-specific message that is courtesy of compressed headers, Bitcoin would be checking for `getheaders`_\n\n \n\n Test Failure
\n\n ```\n dash@6a2649cc721f:/src/dash$ ./test/functional/p2p_initial_headers_sync.py\n 2024-06-17T21:24:09.921000Z TestFramework (INFO): Initializing test directory /tmp/dash_func_test_3gypo3ab\n 2024-06-17T21:24:10.681000Z TestFramework (INFO): Adding a peer to node0\n 2024-06-17T21:24:11.684000Z TestFramework (INFO): Connecting two more peers to node0\n 2024-06-17T21:24:13.689000Z TestFramework (INFO): Verify that peer2 and peer3 don't receive a getheaders after connecting\n 2024-06-17T21:24:15.193000Z TestFramework (ERROR): Assertion failed\n Traceback (most recent call last):\n File \"/src/dash/test/functional/test_framework/test_framework.py\", line 158, in main\n self.run_test()\n File \"./test/functional/p2p_initial_headers_sync.py\", line 60, in run_test\n assert \"getheaders2\" not in peer2.last_message\n AssertionError\n 2024-06-17T21:24:15.695000Z TestFramework (INFO): Stopping nodes\n 2024-06-17T21:24:16.698000Z TestFramework (WARNING): Not cleaning up dir /tmp/dash_func_test_3gypo3ab\n 2024-06-17T21:24:16.698000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/dash_func_test_3gypo3ab/test_framework.log\n 2024-06-17T21:24:16.699000Z TestFramework (ERROR):\n 2024-06-17T21:24:16.699000Z TestFramework (ERROR): Hint: Call /src/dash/test/functional/combine_logs.py '/tmp/dash_func_test_3gypo3ab' to consolidate all logs\n 2024-06-17T21:24:16.699000Z TestFramework (ERROR):\n 2024-06-17T21:24:16.699000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.\n 2024-06-17T21:24:16.699000Z TestFramework (ERROR): https://github.com/dashpay/dash/issues\n 2024-06-17T21:24:16.699000Z TestFramework (ERROR):\n ```\n\n \n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nTop commit has no ACKs.\n\nTree-SHA512: 16b7c42195e197e8b6800c3425b4ff15a124b0e3e0da5c98ca6e22486b52c4ea82f2f05b83e28e838860b1ce76daa1e435c5eae4fb7591a161f26a5fff6189cc","shortMessageHtmlLink":"Merge #6097: backport: merge bitcoin#24024, bitcoin#23880, bitcoin#24909"}},{"before":"bfcc00e067a0c659a60f1b2b5eea2821bb2540fd","after":"e803b320d6ab32abea7fe107dd3c4b0ba3c3e34c","ref":"refs/heads/develop","pushedAt":"2024-08-09T07:32:49.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6181: chore: Merge master 21.1.0 back into develop\n\n8e9dd127c774dbe5a3d50cf446a77c7298a58292 chore: bump version in configure.ac (pasta)\nafb8dc069831d9e970c788c72aeca1f6163c2967 docs: add v21.1.0 release notes and archive v21.0.2 (pasta)\n269dd025e846958ddcb2fc8d9f0684cb3c9d7e17 Merge #6179: chore: update manpages v21.1 (pasta)\na8cb643db816880de0580c8425ef30fa2201fff7 Merge #6175: feat: allow resigning for EHF (pasta)\nde5cc22b0ca1e4698626bb72954ce5d221969a57 Merge #6178: chore: bump protocol version to 70233 (pasta)\n2de4ce51b01109bdd4bc0662c3849a81a65458b1 Merge #6176: test: reduce BRRHeight in regtest (pasta)\n840175ecb482351108b53cf484662445d8822c7d Merge #6174: fix: stop trying to sign pending txes when they are no longer non-locked (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n\n ## What was done?\n\n ## How Has This Been Tested?\n\n ## Breaking Changes\n\n ## Checklist:\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n PastaPastaPasta:\n utACK 058ff45772df76fc9cd4f9202d2825b4c11cac32\n kwvg:\n utACK 058ff45772df76fc9cd4f9202d2825b4c11cac32\n\nTree-SHA512: b619f9754258cece012f817a523f5849128e044ffbe17a28e12f1e8424d11f6a4c8d011a554fce0b106e1d6efee2aa306befdc034b8e47be077ad28c7f39c975","shortMessageHtmlLink":"Merge #6181: chore: Merge master 21.1.0 back into develop"}},{"before":"300529f709a002b32544bbccfca98714400f34f9","after":"5d286a5e647ec54e90ecb3f5ffd49db82dfc7064","ref":"refs/heads/master","pushedAt":"2024-08-08T08:56:43.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"UdjinM6","name":null,"path":"/UdjinM6","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1935069?s=80&v=4"},"commit":{"message":"Merge #6180: [v21.1.x] backport: release v21.1.0\n\n8e9dd127c774dbe5a3d50cf446a77c7298a58292 chore: bump version in configure.ac (pasta)\nafb8dc069831d9e970c788c72aeca1f6163c2967 docs: add v21.1.0 release notes and archive v21.0.2 (pasta)\n269dd025e846958ddcb2fc8d9f0684cb3c9d7e17 Merge #6179: chore: update manpages v21.1 (pasta)\na8cb643db816880de0580c8425ef30fa2201fff7 Merge #6175: feat: allow resigning for EHF (pasta)\nde5cc22b0ca1e4698626bb72954ce5d221969a57 Merge #6178: chore: bump protocol version to 70233 (pasta)\n2de4ce51b01109bdd4bc0662c3849a81a65458b1 Merge #6176: test: reduce BRRHeight in regtest (pasta)\n840175ecb482351108b53cf484662445d8822c7d Merge #6174: fix: stop trying to sign pending txes when they are no longer non-locked (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Backports for v21.1.0, add release notes and\n\n ## What was done?\n See commits\n\n ## How Has This Been Tested?\n Been on devnet\n\n ## Breaking Changes\n None\n\n ## Checklist:\n _Go over all the following points, and put an `x` in all the boxes that apply._\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n knst:\n utACK 8e9dd127c774dbe5a3d50cf446a77c7298a58292\n\nTree-SHA512: 3c968c4f0e06bc88f63bf10f742d39595c45c7fcd4aef1891d2e76d9f443cae1ddd3cb84c787faa189ef3a189a9dd63a7f75e69f5787a47d1281d5b6a445a2a6","shortMessageHtmlLink":"Merge #6180: [v21.1.x] backport: release v21.1.0"}},{"before":"300529f709a002b32544bbccfca98714400f34f9","after":"5d286a5e647ec54e90ecb3f5ffd49db82dfc7064","ref":"refs/heads/v21.1.x","pushedAt":"2024-08-07T12:22:25.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6180: [v21.1.x] backport: release v21.1.0\n\n8e9dd127c774dbe5a3d50cf446a77c7298a58292 chore: bump version in configure.ac (pasta)\nafb8dc069831d9e970c788c72aeca1f6163c2967 docs: add v21.1.0 release notes and archive v21.0.2 (pasta)\n269dd025e846958ddcb2fc8d9f0684cb3c9d7e17 Merge #6179: chore: update manpages v21.1 (pasta)\na8cb643db816880de0580c8425ef30fa2201fff7 Merge #6175: feat: allow resigning for EHF (pasta)\nde5cc22b0ca1e4698626bb72954ce5d221969a57 Merge #6178: chore: bump protocol version to 70233 (pasta)\n2de4ce51b01109bdd4bc0662c3849a81a65458b1 Merge #6176: test: reduce BRRHeight in regtest (pasta)\n840175ecb482351108b53cf484662445d8822c7d Merge #6174: fix: stop trying to sign pending txes when they are no longer non-locked (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Backports for v21.1.0, add release notes and\n\n ## What was done?\n See commits\n\n ## How Has This Been Tested?\n Been on devnet\n\n ## Breaking Changes\n None\n\n ## Checklist:\n _Go over all the following points, and put an `x` in all the boxes that apply._\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n knst:\n utACK 8e9dd127c774dbe5a3d50cf446a77c7298a58292\n\nTree-SHA512: 3c968c4f0e06bc88f63bf10f742d39595c45c7fcd4aef1891d2e76d9f443cae1ddd3cb84c787faa189ef3a189a9dd63a7f75e69f5787a47d1281d5b6a445a2a6","shortMessageHtmlLink":"Merge #6180: [v21.1.x] backport: release v21.1.0"}},{"before":"3c6ef318162a963721c75922e6ec177eac37029d","after":"bfcc00e067a0c659a60f1b2b5eea2821bb2540fd","ref":"refs/heads/develop","pushedAt":"2024-08-07T11:45:23.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6179: chore: update manpages v21.1\n\nd32a03c7e7d7e42dbe42cad1e43b46e69934dc79 chore: update man pages (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n V21.1 preparation\n\n ## What was done?\n Update manpages\n\n ## How Has This Been Tested?\n n/a\n\n ## Breaking Changes\n n/a\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n PastaPastaPasta:\n utACK d32a03c7e7d7e42dbe42cad1e43b46e69934dc79\n\nTree-SHA512: a16036121c48597d80eefcf9232afb8f2da20d7b2e45de4beac31f025f3d8d638f5006e0bb52f706e08235fca172ddfc3309fd143734d37a14776cd7e8842128","shortMessageHtmlLink":"Merge #6179: chore: update manpages v21.1"}},{"before":"4f406bc7f1c2bfa428f6c8925bd420cb978eb66b","after":"3c6ef318162a963721c75922e6ec177eac37029d","ref":"refs/heads/develop","pushedAt":"2024-08-07T11:04:01.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6175: feat: allow resigning for EHF\n\n6f82a561711baacfa28a9825de3d7c9c2f6035b8 feat: add option to AsyncSignIfMember to allow signing same requestID on different msgHashes (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Please see: https://www.dash.org/forum/index.php?threads/ehf-activation-issues.55146/ for a description of this issue\n\n ## What was done?\n Allow re-signing specifically for EHF messages, this is important as due to rotation, and duplicate requestIDs a member will refuse to re-sign when they participate in a later quorum.\n\n ## How Has This Been Tested?\n Devnet deployed with a mix of this version, older versions and current v21.0\n\n ## Breaking Changes\n This doesn't introduce any breaking changes\n\n ## Checklist:\n _Go over all the following points, and put an `x` in all the boxes that apply._\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nTop commit has no ACKs.\n\nTree-SHA512: a758e6363901624d8540983ad09085d47a33fe61e8e576ec4317b051a0f988efb983bd06d9894bcce19c9f587ad703022ce00ceddd3760d7c9d382878f40c2d7","shortMessageHtmlLink":"Merge #6175: feat: allow resigning for EHF"}},{"before":null,"after":"300529f709a002b32544bbccfca98714400f34f9","ref":"refs/heads/v21.1.x","pushedAt":"2024-08-07T09:05:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6167: chore: bump version to 21.0.2\n\n56cc39d178903a9ee6dfbb5f4bbcaa3ee8e5cc68 chore: bump version to 21.0.2 (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n my bad... forgot\n\n ## What was done?\n Bump version in configure.ac\n\n ## How Has This Been Tested?\n\n ## Breaking Changes\n\n ## Checklist:\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK 56cc39d178903a9ee6dfbb5f4bbcaa3ee8e5cc68\n\nTree-SHA512: 7f85d3521e7a264d212a678a3e7ac6d39fceeee209433a02f3c05dcd9dec28ce2893e75a7754331d913ec8215ddda205cf0fbc5c0e0c02eb1afeb899635f29f5","shortMessageHtmlLink":"Merge #6167: chore: bump version to 21.0.2"}},{"before":"5c3f1043fc2901e8ce1d74ee360df1b53f168ea2","after":"4f406bc7f1c2bfa428f6c8925bd420cb978eb66b","ref":"refs/heads/develop","pushedAt":"2024-08-07T06:04:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6178: chore: bump protocol version to 70233\n\n3783b70129c34acd4b0d00397d149b3995a3a3f8 chore: bump protocol version to 70233 (Odysseas Gabrielides)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n\n ## What was done?\n Bumped protocol version to 70233\n\n ## How Has This Been Tested?\n\n ## Breaking Changes\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n PastaPastaPasta:\n utACK 3783b70129c34acd4b0d00397d149b3995a3a3f8\n knst:\n utACK 3783b70129c34acd4b0d00397d149b3995a3a3f8\n\nTree-SHA512: 3f5f04fcc31c5381a1ddce408a3c31876ca6d58ff229c80784ab938be70c3820b773c5db7f0c77fb7a00cc03dbefb70a42b81a0bf17195b78b47cee1e12310b5","shortMessageHtmlLink":"Merge #6178: chore: bump protocol version to 70233"}},{"before":"87c918ac22b48dba1e6659f21f710ea6055cdc03","after":"5c3f1043fc2901e8ce1d74ee360df1b53f168ea2","ref":"refs/heads/develop","pushedAt":"2024-08-07T04:28:00.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6176: test: reduce BRRHeight in regtest\n\n38ecd6f95162b7e25ba90d147e4dd96538d09fe9 test: reduce BRRHeight on regtest (Odysseas Gabrielides)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n In regtest, Block Reward Reallocation is buried at height 2500, which happens after v20 activation.\n\n ## What was done?\n Reduced BRRHeight in regtest from 2500 to 1000.\n The purpose of this change is to simplify regtests of Platform as well.\n Note: This change affects only regtest.\n\n ## How Has This Been Tested?\n tests\n\n ## Breaking Changes\n no, this only affects Regtest (where we make no guarantees about breaking stuff)\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nTop commit has no ACKs.\n\nTree-SHA512: b5a1c2b2c2b70682f266d9d0af9e048a03417c0cb2480eb5ab5838965342b6465acd10d8dac5a0d3c5c5f59f4e36ac5b909a838bc3805c2265a83776e92b4827","shortMessageHtmlLink":"Merge #6176: test: reduce BRRHeight in regtest"}},{"before":"c6ad11ea187ac2a1cc149f011d4cd4dee578a954","after":"99d891b13172c21c1b6fc264aa85984b807be51f","ref":"refs/heads/feat/github-ci","pushedAt":"2024-08-07T03:52:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"use pull_request_target to get access to secrets","shortMessageHtmlLink":"use pull_request_target to get access to secrets"}},{"before":"a9979ebf73c1b0e22435137bdaee518bc2fa9e05","after":"87c918ac22b48dba1e6659f21f710ea6055cdc03","ref":"refs/heads/develop","pushedAt":"2024-08-07T02:20:16.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6138: backport: merge bitcoin#22840, #22937, #23446, #23522, #24026, #24104, #24167, #20744, partial bitcoin#23469, #24169 (replace boost::filesystem with std::filesystem)\n\n0f239203a890494b3f147c9060f039d7c2eb5c37 partial bitcoin#24169: Add --enable-c++20 option (Kittywhiskers Van Gogh)\na3b79267e02e407d2980451b7bb6d53e194fdcfb merge bitcoin#20744: Use std::filesystem. Remove Boost Filesystem & System (Kittywhiskers Van Gogh)\nbe7ac493d031b47dd8890817df0f018eb8ff1cfa merge bitcoin#24167: consistently use fsbridge:: for ifstream / ofstream (Kittywhiskers Van Gogh)\n7ffea4348f1d42924ac58c4c7a08d5f3025739df merge bitcoin#24104: Make compatible with boost 1.78 (Kittywhiskers Van Gogh)\n7c270e68830562982045239a2b006a0503647a8a merge bitcoin#24026: Block unsafe std::string fs::path conversion copy_file calls (Kittywhiskers Van Gogh)\nb0d2484a0b47e606fe409e7331e516dd26ec4eea merge bitcoin#23522: Improve fs::PathToString documentation (Kittywhiskers Van Gogh)\n20d359b5706ca72c2edf27072355b4bb67b78e51 partial bitcoin#23469: Remove Boost build note from build-unix.md (Kittywhiskers Van Gogh)\n193f6fde2ee632bbde4e1472272e032a794018e3 merge bitcoin#23446: Mention that BerkeleyDB is for legacy wallet in build-unix (Kittywhiskers Van Gogh)\necfac10b8e4265f2dd234241afcfcbcf0857c54d merge bitcoin#22937: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method (Kittywhiskers Van Gogh)\n23fe7e2f07c0d9caa6d0ddb6a330971bf479f261 chore: dashify symbols in some unit tests (Kittywhiskers Van Gogh)\n28b96a071d1630ac7b2c5266009d8c1e979e3897 merge bitcoin#22840: fix unoptimized libraries in depends (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n * Depends on https://github.com/dashpay/dash/pull/6085\n * Depends on https://github.com/dashpay/dash/pull/6137\n * Dependency for https://github.com/dashpay/dash/pull/6150\n\n ## Breaking Changes\n\n None observed.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n knst:\n utACK 0f239203a890494b3f147c9060f039d7c2eb5c37\n PastaPastaPasta:\n utACK 0f239203a890494b3f147c9060f039d7c2eb5c37\n\nTree-SHA512: 4b8f0ae55185ece27d8084a5339196b7ed993c8138f4c59a0db3e16729d4edf4a59a68a8c7309c32df57734c07182821c4878b55c253da5df763204ad7158426","shortMessageHtmlLink":"Merge #6138: backport: merge bitcoin#22840, bitcoin#22937, bitcoin#23446"}},{"before":"9b03903e94ce26d8fc5992d994db0f329bdca1e9","after":"a9979ebf73c1b0e22435137bdaee518bc2fa9e05","ref":"refs/heads/develop","pushedAt":"2024-08-07T02:04:29.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6131: feat: make a support of Qt app to show Platform transfer Tx\n\n21f174aff107f9aec9b758a00bde67b96ad3cd55 feat: improve query categorisation in Qt App (Konstantin Akimov)\nc863473286e2a34bff6abf2fb58611ad239c65ab test: add spending asset unlock tx in functional tests (Konstantin Akimov)\n1fb67ece0e99baf668687538d9d22217bdc70e4f feat: make a support of Qt app to show Platform Transfer transaction as a new type of transaction (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Transfers from platform have incorrectly shown amount in Dash Core wallet app.\n They also shown in Qt app as self-send that is not completely true.\n\n ## What was done?\n Added new type of transaction to Qt App, added a filter for its type, fixed calculation of output for tx records.\n As well added a new type of transaction `platform-transfer` in rpc output of `gettransaction` RPC\n\n ## How Has This Been Tested?\n Make a Platform Transfer transaction on RegTest and check it in Dash Core\n\n \n\n Helper to see it: export dpath=/tmp/dash_func_test_PATHPATH/ ; src/qt/dash-qt -regtest -conf=$dpath/node0/dash.conf -datadir=$dpath/node0/ -debug=0 -debuglogfile=/dev/stdout\n\n ## Breaking Changes\n There's new type of transaction \"platform-transfer\" in rpc output of `gettransaction`.\n\n **This PR DOES NOT change any consensus rules.**\n Breaking changes that makes withdrawal transaction immature is moved to https://github.com/dashpay/dash/pull/6128\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nTop commit has no ACKs.\n\nTree-SHA512: ec2a54a910f121ad30ff8e94cf17080b5b3c651872e9bc3de9ec0924ca7f7a0e526b74b05cde26aaf860e3809e67f66142112319a69c216527e5bcb1b8a2b8f6","shortMessageHtmlLink":"Merge #6131: feat: make a support of Qt app to show Platform transfer Tx"}},{"before":"bea3fdd5100276dc49d74a1c004a35f1770493e7","after":"c6ad11ea187ac2a1cc149f011d4cd4dee578a954","ref":"refs/heads/feat/github-ci","pushedAt":"2024-08-06T08:02:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"use pull_request_target to get access to secrets","shortMessageHtmlLink":"use pull_request_target to get access to secrets"}},{"before":"c8ba6ebfe51a4f4b710ee452e49a96c97031ba90","after":null,"ref":"refs/heads/github-ci-wip","pushedAt":"2024-08-06T08:01:44.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEnRSCMgA","startCursor":null,"endCursor":null}},"title":"Activity Β· dashpay/dash"}