-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: crash on wallet encrypt #5715
Comments
I added a bunch of asserts into this to figure out what exactly is failing and it appears to me to be this that is actually failing Line 134 in 65ff12c
|
Pretty sure this happens because all keys are encrypted in a single Transaction (and we do this because if something fails we don't end up with half keys encrypted on db and half keys still unencrypted or still not saved on db). In this case there are too many keys in a single transaction, which gets too big and at some point we fail to write in the WalletBatch. |
A solution would be doing multiple smaller transactions, but then a smart way to revert everything in case of failure should be implemented too |
Steps to reproduce
Stack trace
The text was updated successfully, but these errors were encountered: