forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: key pool refill on sqlite wallet spams "Topping up key pool" #5730
Comments
5 tasks
PastaPastaPasta
pushed a commit
that referenced
this issue
Jan 31, 2024
## Issue being fixed or feature implemented Trivial bug: `keypoolrefill` internally updates the status of the progress bar each second. ``` m_storage.UpdateProgress(strMsg, static_cast<int>(dProgress)); ``` However it can happen that one second is not enough time to make significant progress and `static_cast<int>(dProgress) = 0`. Calling the function with `0` as progress opens a new progress bar and this led to problems like #5730 ## What was done? trivially make sure to update the progress only if the parameter is >0 ## How Has This Been Tested? rpc does not spam anymore ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [X] I have performed a self-review of my own code - [X] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
--without-bdb
to configureThe text was updated successfully, but these errors were encountered: