Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardize S3 endpoint handling and add option for path-style #368

Merged
merged 1 commit into from
Nov 7, 2024
Merged

standardize S3 endpoint handling and add option for path-style #368

merged 1 commit into from
Nov 7, 2024

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented Nov 7, 2024

This does two things.

  1. Standardize AWS endpoint resolution. Rather than having a custom endpoint resolver, we can just use the option for BaseEndpoint, and let the standard default resolver do the right thing. This is simpler with less code.
  2. Add an option to use path-style bucket addressing rather than virtual-host-style. Of course, docs are updated.

The option is added to the config file, as well as the CLI.

@deitch
standardize S3 endpoint handling and add option for path-style
82fceb3 
Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch merged commit d1728a5 into master Nov 7, 2024
2 checks passed
@deitch deitch deleted the standardize-s3-endpoint-resolution branch November 7, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deitch